From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Kurochkin Newsgroups: gmane.emacs.devel Subject: Re: text_property_stickiness() ignores `text-property-default-nonsticky' Date: Tue, 05 Jul 2011 06:15:55 +0400 Message-ID: <87tyb15v6s.fsf@gmail.com> References: <87aacuq5p2.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1309832190 13299 80.91.229.12 (5 Jul 2011 02:16:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 5 Jul 2011 02:16:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 05 04:16:26 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QdvBZ-0005fG-Rl for ged-emacs-devel@m.gmane.org; Tue, 05 Jul 2011 04:16:26 +0200 Original-Received: from localhost ([::1]:46940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdvBY-0003Wn-LD for ged-emacs-devel@m.gmane.org; Mon, 04 Jul 2011 22:16:25 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdvBF-0003Wh-Mh for emacs-devel@gnu.org; Mon, 04 Jul 2011 22:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdvBE-00063y-7v for emacs-devel@gnu.org; Mon, 04 Jul 2011 22:16:05 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:50965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdvBE-00063s-39 for emacs-devel@gnu.org; Mon, 04 Jul 2011 22:16:04 -0400 Original-Received: by bwd14 with SMTP id 14so5690731bwd.0 for ; Mon, 04 Jul 2011 19:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=yfxExJzkyTUc3WEQZm3/6qPXhpc0lFo9KTiQU6pMMOk=; b=IcGc1CbZCIZ8Jl1e2mVVi0wKfaSzIitpNKIibCJNfDiMN/Qz6YGKykWm8A4DOdxQiv AMiPyyf3RHkbMmakJeEII1fkeIM8Bq3ZRARMJ2v3wmdIftbehsjcfm5mqjAj8IPZ4UKI 25l8z06HWXYbenRKFcB1+C+hqQrlTfHFNpA70= Original-Received: by 10.204.10.67 with SMTP id o3mr6184515bko.161.1309832162390; Mon, 04 Jul 2011 19:16:02 -0700 (PDT) Original-Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id f16sm296446bke.4.2011.07.04.19.16.00 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Jul 2011 19:16:01 -0700 (PDT) In-Reply-To: User-Agent: Notmuch/0.5-321-g41686e2 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141561 Archived-At: On Mon, 04 Jul 2011 12:53:00 -0400, Stefan Monnier wrote: > >>>>> "Dmitry" == Dmitry Kurochkin writes: > > > Hello. > > I am trying to make `keymap' property rear-nonsticky, so that it does > > not affect the next character after the region the property is applied > > to. If I do it by setting rear-nonsticky text property to 't or to a > > list that contains 'keymap, it works fine: > > > (let ((map (make-sparse-keymap))) > > (define-key map (kbd "RET") 'bug) > > (switch-to-buffer "test") > > (insert "123456") > > (put-text-property 1 4 'keymap map) > > (put-text-property (point-min) (point-max) 'rear-nonsticky '(keymap)) > > (goto-char 4) > > (message "keymap: %s" (get-text-property (point) 'keymap)) > > (message "key-binding: %s" (key-binding (kbd "RET")))) > > > But if I set `text-property-default-nonsticky' variable instead, it does > > not work: > > > (let ((map (make-sparse-keymap))) > > (define-key map (kbd "RET") 'bug) > > (switch-to-buffer "test") > > (insert "123456") > > (put-text-property 1 4 'keymap map) > > (make-local-variable 'text-property-default-nonsticky) > > (add-to-list 'text-property-default-nonsticky '(keymap . t)) > > (goto-char 4) > > (message "keymap: %s" (get-text-property (point) 'keymap)) > > (message "key-binding: %s" (key-binding (kbd "RET")))) > > > Looking through the code, I got down to text_property_stickiness() > > function in src/textprop.c, which is used by get_pos_property(), which > > is used by get_local_map(). There are checks for `front-sticky' and > > `rear-nonsticky' properties, but no checks for > > `text-property-default-nonsticky' variable. > > Indeed. Does the patch below fix your problem? > The patch below would not work because it checks for nil in `text-property-default-nonsticky' instead of 't. But your commit r104949 fixes the issue. Thank you! Will it get included in some bugfix emacs release anytime soon? Or only emacs24? It seems that text_property_stickiness() or get_pos_property() or some other elisp interface to get "what inherited property value for PROP is at this POS" would be useful. For example, `widget-field-activate' should work at the end of widget. Currently, `widget-field-activate' is called at the end of widget, because keymap is rear-sticky but it does not call widget's action because `widget-field-at' does not respect stickiness. What do you think? Regards, Dmitry > > Before opening false bug reports, I would like to confirm that this is > > an issue indeed, and it is not me doing something stupid. > > "False" bug reports are not something you should be afraid of. > I.e. feel free to use M-x report-emacs-bug when something looks like > a bug *to you*, even if we decide that it's a not a bug from our point > of view. > > > Stefan > > > === modified file 'src/textprop.c' > --- src/textprop.c 2011-06-25 13:00:55 +0000 > +++ src/textprop.c 2011-07-04 16:49:42 +0000 > @@ -1707,10 +1707,14 @@ > { > Lisp_Object prev_pos, front_sticky; > int is_rear_sticky = 1, is_front_sticky = 0; /* defaults */ > + Lisp_Object default = Fassq (prop, Vtext_property_default_nonsticky); > > if (NILP (buffer)) > XSETBUFFER (buffer, current_buffer); > > + if (CONSP (default) && NILP (XCDR (default))) > + is_rear_sticky = 0; > + > if (XINT (pos) > BUF_BEGV (XBUFFER (buffer))) > /* Consider previous character. */ > { >