Bug: Minor Bug: COOKIE_DATA property breaks parent statistics [7.5 (release_7.5.24.g5f0ef)]

Bug: Minor Bug: COOKIE_DATA property breaks parent statistics [7.5 (release_7.5.24.g5f0ef)]

[Bernt Hansen]

I've run into a minor bug with cookie statistics.

The COOKIE_DATA property seems to break parent task statistics when it
is set to 'recursive'.

In the org file below task one/two/foo/a has the COOKIE_DATA property
set to recursive.  Changing the state of task 'a' does not change the
statistics cookie of the parent task 'foo' when 'a' changes from TODO to
DONE or DONE to TODO.

I cannot update the statistics of task 'foo' manually after changing
task 'a' by hitting C-c # on the 'foo' headline.  If I update one of the
other tasks under 'foo' then the statistics are updated correctly.

I think this should update automagically when the state of 'a' changes.

Regards,
Bernt

--8<---------------cut here---------------start------------->8---
* TODO one [0/1] [0%]

** TODO two [0/3] [0%]

*** TODO foo [1/4]

**** TODO a [3/6]
:PROPERTIES:
:COOKIE_DATA: recursive
:END:

***** TODO a.1

****** TODO a.1.1

****** DONE a.1.2
CLOSED: [2011-03-09 Wed 22:50]
:LOGBOOK:
- State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
:END:

****** TODO a.1.3
***** DONE a.2
CLOSED: [2011-03-09 Wed 22:50]
:LOGBOOK:
- State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
:END:

***** DONE a.3
CLOSED: [2011-03-09 Wed 22:50]
:LOGBOOK:
- State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
:END:

**** TODO b
CLOSED: [2011-03-09 Wed 22:50]
:LOGBOOK:
- State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
:END:

**** DONE c
CLOSED: [2011-03-09 Wed 22:50]
:LOGBOOK:
- State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
:END:

**** TODO d

*** TODO bar

*** TODO baz

--8<---------------cut here---------------end--------------->8---


Emacs  : GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0)
 of 2010-12-11 on raven, modified by Debian
Package: Org-mode version 7.5 (release_7.5.24.g5f0ef)
-- 
Bernt

Re: Bug: Minor Bug: COOKIE_DATA property breaks parent statistics [7.5 (release_7.5.24.g5f0ef)]

[Nicolas Goaziou]

Hello,

Bernt Hansen <bernt@norang.ca> writes:

> I've run into a minor bug with cookie statistics.
>
> The COOKIE_DATA property seems to break parent task statistics when it
> is set to 'recursive'.
>
> In the org file below task one/two/foo/a has the COOKIE_DATA property
> set to recursive.  Changing the state of task 'a' does not change the
> statistics cookie of the parent task 'foo' when 'a' changes from TODO to
> DONE or DONE to TODO.
>
> I cannot update the statistics of task 'foo' manually after changing
> task 'a' by hitting C-c # on the 'foo' headline.  If I update one of the
> other tasks under 'foo' then the statistics are updated correctly.
>
> I think this should update automagically when the state of 'a' changes.
>
> Regards,
> Bernt
>
> * TODO one [0/1] [0%]
>
> ** TODO two [0/3] [0%]
>
> *** TODO foo [1/4]
>
> **** TODO a [3/6]
> :PROPERTIES:
> :COOKIE_DATA: recursive
> :END:
>
> ***** TODO a.1
>
> ****** TODO a.1.1
>
> ****** DONE a.1.2
> CLOSED: [2011-03-09 Wed 22:50]
> :LOGBOOK:
> - State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
> :END:
>
> ****** TODO a.1.3
> ***** DONE a.2
> CLOSED: [2011-03-09 Wed 22:50]
> :LOGBOOK:
> - State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
> :END:
>
> ***** DONE a.3
> CLOSED: [2011-03-09 Wed 22:50]
> :LOGBOOK:
> - State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
> :END:
>
> **** TODO b
> CLOSED: [2011-03-09 Wed 22:50]
> :LOGBOOK:
> - State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
> :END:
>
> **** DONE c
> CLOSED: [2011-03-09 Wed 22:50]
> :LOGBOOK:
> - State "DONE"       from "TODO"       [2011-03-09 Wed 22:50]
> :END:
>
> **** TODO d
>
> *** TODO bar
>
> *** TODO baz

I have pushed a fix in master branch that should solve the problem at
hand. Could you test it a bit and tell me if it does the job?

Regards,

-- 
Nicolas Goaziou

Re: Bug: Minor Bug: COOKIE_DATA property breaks parent statistics [7.5 (release_7.5.24.g5f0ef)]

[Bernt Hansen]

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Hello,
>
> Bernt Hansen <bernt@norang.ca> writes:
>
>> I've run into a minor bug with cookie statistics.
>>
>> The COOKIE_DATA property seems to break parent task statistics when it
>> is set to 'recursive'.
>>
>
> I have pushed a fix in master branch that should solve the problem at
> hand. Could you test it a bit and tell me if it does the job?

Your fix for this works great.  Thanks!

Regards,
-- 
Bernt