From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Newsgroups: gmane.emacs.bugs Subject: bug#10150: deactive->inactive, inactivate->deactivate spelling fixes Date: Tue, 03 Jan 2012 17:55:55 +0100 Message-ID: <87ty4c209w.fsf@gmail.com> References: <4ED2CA07.2090202@cs.ucla.edu> <87d3ccfqcm.fsf@gmail.com> <4ED49229.2030107@cs.ucla.edu> <878vmzf8wb.fsf@gmail.com> <4EFEA7CA.9050608@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1325609820 19809 80.91.229.12 (3 Jan 2012 16:57:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 3 Jan 2012 16:57:00 +0000 (UTC) Cc: 10150@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 03 17:56:55 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ri7fS-0004f1-3u for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jan 2012 17:56:54 +0100 Original-Received: from localhost ([::1]:38256 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri7fR-000555-F9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jan 2012 11:56:53 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:35585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri7fL-0004ut-ON for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2012 11:56:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ri7fH-0004dC-Hi for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2012 11:56:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri7fH-0004d7-G4 for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2012 11:56:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Ri7iU-0003gl-HQ for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2012 12:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Jan 2012 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10150-submit@debbugs.gnu.org id=B10150.132560996014109 (code B ref 10150); Tue, 03 Jan 2012 17:00:02 +0000 Original-Received: (at 10150) by debbugs.gnu.org; 3 Jan 2012 16:59:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ri7ho-0003fV-Kj for submit@debbugs.gnu.org; Tue, 03 Jan 2012 11:59:20 -0500 Original-Received: from mail-ee0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ri7hm-0003fO-Th for 10150@debbugs.gnu.org; Tue, 03 Jan 2012 11:59:19 -0500 Original-Received: by eekc14 with SMTP id c14so16957408eek.3 for <10150@debbugs.gnu.org>; Tue, 03 Jan 2012 08:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:content-transfer-encoding; bh=MftsvVyrrOtaGumFbgxm03qgRDQWZ6f4YZAj5nJtqME=; b=sucOQRV3JJ4cMq+xf46rbOtGXIYJngaeR3cgch+O5OuD9nnAOZxv44nogUaLmnrOCl rK3FehFCL69ynXBsxT45YBuH0XT9/q8bXZCY6blladYyVc+8V1zJM8IexP1g1KO+HrmM 2F1F7D3dZRWGzE8Ht8k5nIunbJUSdSieOdObs= Original-Received: by 10.14.35.80 with SMTP id t56mr21510297eea.1.1325609758533; Tue, 03 Jan 2012 08:55:58 -0800 (PST) Original-Received: from localhost (176.119.broadband10.iol.cz. [90.177.119.176]) by mx.google.com with ESMTPS id u53sm159962997eeu.6.2012.01.03.08.55.56 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Jan 2012 08:55:57 -0800 (PST) In-Reply-To: <4EFEA7CA.9050608@cs.ucla.edu> (Paul Eggert's message of "Fri, 30 Dec 2011 22:12:26 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 03 Jan 2012 12:00:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55381 Archived-At: On Sat, 31 Dec 2011 07:12:26 +0100 Paul Eggert wrote: > On 11/29/11 03:47, =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec wrote: >> IMO all commands, hooks and user variables definitely need deprecation, >> the rest should at least be mentioned in NEWS. > > OK, thanks, attached is an improved version of the patch that > should do all that. I'll also look at improving the > other patches I recently submitted re fixing spelling > problems in the code. Thank you! Several problems I noticed: 1) `hangul-input-method-inactivate', `quail-inactivate', `robin-inactivate' and `ucs-input-inactivate' are all interactive functions (=3D commands), but you still just rename them without any deprecation (cf. `define-obsolete-function-alias'). 2) You only use `make-obsolete-variable' to mark user variables obsolete (and retain both the original and the new defcustoms), which will produce compiler warnings for the old variable, but doesn't provide any clear connection between the two. It would be better to use `define-obsolete-variable-alias' (which presumably also prevents other problems, see its docstring) and only use `defcustom' for the new variable(s). 3) The new or changed `defcustoms' should get a :version tag. --=20 =C5=A0t=C4=9Bp=C3=A1n