org-publish-validate-link ?

org-publish-validate-link ?

[François Pinard]

Hello again!

The manual, in [[info:org#Publishing%20links][Publishing links]],
speaks about an *org-publish-validate-link* function which does not seem
to exist in Org mode sources.  Is the function missing, or the
documentation misleading? :-)

François

Re: org-publish-validate-link ?

[Nick Dokos]

François Pinard <pinard@iro.umontreal.ca> wrote:


> The manual, in [[info:org#Publishing%20links][Publishing links]],
> speaks about an *org-publish-validate-link* function which does not seem
> to exist in Org mode sources.  Is the function missing, or the
> documentation misleading? :-)
> 

It was removed by Sebastian Rose in a cleaning binge back in 2010,
with the rationale that it was not being used anywhere:

,----
| commit 339d6fe4bbf7b9858c6323d01f32d0c73a4cd3a8
| Author: Sebastian Rose <sebastian_rose@gmx.de>
| Date:   Thu May 13 13:43:53 2010 +0200
| 
|         ...
|     
|     	* org-publish.el (org-publish-validate-link) was not used
|     	anywhere. Removed.
|     
|         ...
`----

Apparently that had happened before because there is also this:

,----
| commit d1f91f7e936b1d3caf1b17f0fe755ee085256442
| Author: Carsten Dominik <carsten.dominik@gmail.com>
| Date:   Sun Nov 2 16:20:40 2008 +0100
| 
|     Re-introduce the org-publish-validate-link function.
`----

but I cannot find the previous deletion.

It was originally introduced with the following commit:

,----
| commit 8fd900c6842d6f8d216ae6989b34c8de4a874e79
| Author: Carsten Dominik <dominik@nb-dominik2.science.uva.nl>
| Date:   Thu Jan 31 11:32:08 2008 +0100
| 
|     Release 4.40
| 
|     ...
| 
| +;;;; Checking filenames against this hash
| +
| +
| +(defun org-publish-validate-link (link)
| +  (gethash (file-truename link) org-publish-files))
| +
| +
| 
|     ...
`----

I presume it's time to add it back in, this time with a note: "Do NOT
delete: this function may look unused, but it's referred to from the
manual!"

Archaelogy is kind of fun ;-)

Nick

Re: org-publish-validate-link ?

[Bernt Hansen]

Nick Dokos <nicholas.dokos@hp.com> writes:

> François Pinard <pinard@iro.umontreal.ca> wrote:
>
>
>> The manual, in [[info:org#Publishing%20links][Publishing links]],
>> speaks about an *org-publish-validate-link* function which does not seem
>> to exist in Org mode sources.  Is the function missing, or the
>> documentation misleading? :-)
>> 
>
> It was removed by Sebastian Rose in a cleaning binge back in 2010,
> with the rationale that it was not being used anywhere:
>
> ,----
> | commit 339d6fe4bbf7b9858c6323d01f32d0c73a4cd3a8
> | Author: Sebastian Rose <sebastian_rose@gmx.de>
> | Date:   Thu May 13 13:43:53 2010 +0200
> | 
> |         ...
> |     
> |     	* org-publish.el (org-publish-validate-link) was not used
> |     	anywhere. Removed.
> |     
> |         ...
> `----
>
> Apparently that had happened before because there is also this:
>
> ,----
> | commit d1f91f7e936b1d3caf1b17f0fe755ee085256442
> | Author: Carsten Dominik <carsten.dominik@gmail.com>
> | Date:   Sun Nov 2 16:20:40 2008 +0100
> | 
> |     Re-introduce the org-publish-validate-link function.
> `----
>
> but I cannot find the previous deletion.

From 
git log -Sdefun\ org-publish-validate-link

,----
| commit b05bc10e6794c902df679b906d8bd6ec3f5633a9
| Author: Bastien Guerry <bzg@altern.org>
| Date:   Sun Mar 2 14:14:52 2008 +0000
| 
|     Cleaned up code.
| 
`----

-Bernt

>
> It was originally introduced with the following commit:
>
> ,----
> | commit 8fd900c6842d6f8d216ae6989b34c8de4a874e79
> | Author: Carsten Dominik <dominik@nb-dominik2.science.uva.nl>
> | Date:   Thu Jan 31 11:32:08 2008 +0100
> | 
> |     Release 4.40
> | 
> |     ...
> | 
> | +;;;; Checking filenames against this hash
> | +
> | +
> | +(defun org-publish-validate-link (link)
> | +  (gethash (file-truename link) org-publish-files))
> | +
> | +
> | 
> |     ...
> `----
>
> I presume it's time to add it back in, this time with a note: "Do NOT
> delete: this function may look unused, but it's referred to from the
> manual!"
>
> Archaelogy is kind of fun ;-)
>
> Nick

Re: org-publish-validate-link ?

[Nick Dokos]

Bernt Hansen <bernt@norang.ca> wrote:

> Nick Dokos <nicholas.dokos@hp.com> writes:
> 
> > ...
> > but I cannot find the previous deletion.
> 
> From 
> git log -Sdefun\ org-publish-validate-link
> 
> ,----
> | commit b05bc10e6794c902df679b906d8bd6ec3f5633a9
> | Author: Bastien Guerry <bzg@altern.org>
> | Date:   Sun Mar 2 14:14:52 2008 +0000
> | 
> |     Cleaned up code.
> | 
> `----
> 

Thanks!

Nick