From: Chong Yidong <cyd@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: darthandrus@gmail.com, 11068@debbugs.gnu.org
Subject: bug#11068: 24.0.94; Face-remapped background does not extend to end of window
Date: Sat, 24 Mar 2012 22:17:41 +0800 [thread overview]
Message-ID: <87ty1ekrqy.fsf@gnu.org> (raw)
In-Reply-To: <83obrmtbsy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Mar 2012 14:37:17 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> /* Face extension extends the background and box of IT->face_id
> to the end of the line. If the background equals the background
> of the frame, we don't have to do anything. */
> if (it->face_before_selective_p)
> face = FACE_FROM_ID (f, it->saved_face_id);
> + else if (it->face_id == DEFAULT_FACE_ID)
> + face = default_face;
> else
> face = FACE_FROM_ID (f, it->face_id);
This looks a bit strange. Why is DEFAULT_FACE_ID handled specially
here? Shouldn't we be checking for face remapping no matter what the
face_id is?
next prev parent reply other threads:[~2012-03-24 14:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 20:49 bug#11068: 24.0.94; Face-remapped background does not extend to end of window Ivan Andrus
[not found] ` <handler.11068.B.13324512277363.ack@debbugs.gnu.org>
2012-03-22 21:18 ` bug#11068: Acknowledgement (24.0.94; Face-remapped background does not extend to end of window) Ivan Andrus
2012-03-22 21:33 ` Glenn Morris
2012-03-22 21:31 ` bug#11069: 24.0.94; Face-remapped background does not extend to end of window Glenn Morris
2012-03-23 10:36 ` bug#11068: " Eli Zaretskii
2012-03-23 10:48 ` Ivan Andrus
2012-03-24 12:37 ` Eli Zaretskii
2012-03-24 13:42 ` martin rudalics
2012-03-24 14:12 ` Eli Zaretskii
2012-03-24 19:48 ` martin rudalics
2012-03-24 20:47 ` Eli Zaretskii
2012-03-25 12:54 ` martin rudalics
2012-03-25 17:22 ` Eli Zaretskii
2012-03-25 19:19 ` martin rudalics
2012-03-25 19:53 ` Stefan Monnier
2012-03-25 20:44 ` martin rudalics
2012-03-25 21:49 ` Eli Zaretskii
2012-03-25 21:53 ` Eli Zaretskii
2012-03-26 7:05 ` martin rudalics
2012-03-26 19:32 ` Eli Zaretskii
2012-03-27 9:23 ` martin rudalics
2012-03-27 18:40 ` Eli Zaretskii
2012-03-30 7:35 ` martin rudalics
2012-03-30 8:18 ` Eli Zaretskii
2012-03-30 10:14 ` martin rudalics
2012-03-30 11:42 ` Eli Zaretskii
2012-03-31 10:29 ` Eli Zaretskii
2012-03-30 10:47 ` martin rudalics
2012-03-24 18:04 ` Stefan Monnier
2012-03-24 19:48 ` martin rudalics
2012-03-24 14:17 ` Chong Yidong [this message]
2012-03-24 14:40 ` Eli Zaretskii
2012-03-25 3:01 ` Chong Yidong
2012-03-25 4:02 ` Eli Zaretskii
2012-03-25 6:20 ` Chong Yidong
2012-03-25 12:55 ` martin rudalics
2012-03-25 17:26 ` Eli Zaretskii
2012-03-25 19:20 ` martin rudalics
2012-03-25 17:51 ` Eli Zaretskii
2012-03-26 4:16 ` Chong Yidong
2012-03-26 19:35 ` Eli Zaretskii
2012-03-30 8:49 ` Eli Zaretskii
2012-03-25 12:54 ` martin rudalics
2012-03-25 17:25 ` Eli Zaretskii
2012-03-25 19:19 ` martin rudalics
2012-03-25 21:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty1ekrqy.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=11068@debbugs.gnu.org \
--cc=darthandrus@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.