all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: 11328@debbugs.gnu.org
Subject: bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code
Date: Wed, 25 Apr 2012 20:42:36 +0200	[thread overview]
Message-ID: <87ty07hcv7.fsf@gmail.com> (raw)
In-Reply-To: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com>

Hi Drew,
about fluid variables in dired code, particularly in
`dired-create-files', I would say instead of fluid "obscure", as they
are variables that must be in any calls of `dired-create-files' within a
lambda used as argument of this function.
I think it would be better to have explicit arg in the caller and have
also the lambda's there.
The code would be easier to read and understand and no need to have
obscure comments such as "fluid variable...etc".

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 






  reply	other threads:[~2012-04-25 18:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 17:37 bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code Drew Adams
2012-04-24 17:49 ` Drew Adams
2012-04-24 18:22   ` Drew Adams
2012-04-25 13:40     ` Nix
2012-04-25 16:26       ` Drew Adams
2012-04-25 18:42         ` Thierry Volpiatto [this message]
2012-04-25 21:51           ` Drew Adams
2012-04-26  5:48             ` Thierry Volpiatto
2012-04-26 14:09               ` Drew Adams
2012-04-26 15:35               ` Drew Adams
2012-04-26 18:38                 ` Thierry Volpiatto
2012-04-24 18:54 ` Stefan Monnier
2014-02-09  4:32 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ty07hcv7.fsf@gmail.com \
    --to=thierry.volpiatto@gmail.com \
    --cc=11328@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.