From: Juri Linkov <juri@jurta.org>
To: Dani Moncayo <dmoncayo@gmail.com>
Cc: 12078@debbugs.gnu.org
Subject: bug#12078: 24.1; Improve the I-search prompt
Date: Sun, 29 Jul 2012 03:35:31 +0300 [thread overview]
Message-ID: <87txwr2ylo.fsf@mail.jurta.org> (raw)
In-Reply-To: <CAH8Pv0iYtVu7pxC-=5m-ZH=ojoPWrfUrTQNF-yLM37vd_i+TVg@mail.gmail.com> (Dani Moncayo's message of "Sat, 28 Jul 2012 19:56:48 +0200")
> Failing I-search: foobar
> Overwrapped I-search: foobar
> Failing overwrapped I-search: foobar
> Failing I-search: foobar [initial node]
>
> would be
>
> I-search: foobar [failing]
> I-search: foobar [overwrapped]
> I-search: foobar [failing, overwrapped]
> I-search: foobar [failing, initial node]
I think we should distinguish between momentary messages and search states.
For instance, "failing" is a momentary message, but "overwrapped"
is a search state. It would be very annoying to display persistent
search states like "overwrapped" at the end of the search prompt.
Meanwhile, for consistency with the isearch message "end of manual",
I propose to rename its counterpart "initial node" to "end of node":
=== modified file 'lisp/info.el'
--- lisp/info.el 2012-07-10 11:51:54 +0000
+++ lisp/info.el 2012-07-29 00:23:39 +0000
@@ -342,12 +340,12 @@ (defcustom Info-search-whitespace-regexp
(defcustom Info-isearch-search t
"If non-nil, isearch in Info searches through multiple nodes.
Before leaving the initial Info node, where isearch was started,
-it fails once with the error message [initial node], and with
+it fails once with the error message [end of node], and with
subsequent C-s/C-r continues through other nodes without failing
with this error message in other nodes. When isearch fails for
-the rest of the manual, it wraps around the whole manual and
-restarts the search from the top/final node depending on
-search direction.
+the rest of the manual, it displays the error message [end of manual],
+wraps around the whole manual and restarts the search from the top/final
+node depending on search direction.
Setting this option to nil restores the default isearch behavior
with wrapping around the current Info node."
@@ -1863,7 +1867,7 @@ (defun Info-search (regexp &optional bou
(not bound)
(or give-up (and found (not (and (> found opoint-min)
(< found opoint-max))))))
- (signal 'search-failed (list regexp "initial node")))
+ (signal 'search-failed (list regexp "end of node")))
;; If no subfiles, give error now.
(if give-up
next prev parent reply other threads:[~2012-07-29 0:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 17:56 bug#12078: 24.1; Improve the I-search prompt Dani Moncayo
2012-07-29 0:35 ` Juri Linkov [this message]
2012-07-29 18:04 ` Juri Linkov
2012-07-30 0:45 ` Dani Moncayo
2012-07-30 9:25 ` Stefan Monnier
2012-07-30 9:30 ` Dani Moncayo
2012-07-30 23:03 ` Stefan Monnier
2012-07-30 23:50 ` Dani Moncayo
2012-08-01 23:29 ` Stefan Monnier
2012-08-08 8:06 ` Juri Linkov
2012-08-08 8:30 ` Dani Moncayo
2020-09-18 15:05 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txwr2ylo.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=12078@debbugs.gnu.org \
--cc=dmoncayo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.