From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.bugs Subject: bug#12345: 24.2.50; doc string of `text-scale-adjust' Date: Tue, 11 Sep 2012 16:53:06 +0200 Message-ID: <87txv4zk4t.fsf@altern.org> References: <703AC3C70837474CADDB99BA7E9E59A1@us.oracle.com> <87vcfkr884.fsf@altern.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1347375220 12834 80.91.229.3 (11 Sep 2012 14:53:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2012 14:53:40 +0000 (UTC) Cc: 12345@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 11 16:53:43 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TBRqP-0006Vh-Sg for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 16:53:42 +0200 Original-Received: from localhost ([::1]:40469 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRqM-0004uC-Gt for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 10:53:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRqA-0004p5-Rc for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 10:53:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBRq5-00040T-Rx for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 10:53:26 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRq5-00040P-OL for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 10:53:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TBRqk-0007HM-6T for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 10:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bastien Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12345-submit@debbugs.gnu.org id=B12345.134737523127962 (code B ref 12345); Tue, 11 Sep 2012 14:54:02 +0000 Original-Received: (at 12345) by debbugs.gnu.org; 11 Sep 2012 14:53:51 +0000 Original-Received: from localhost ([127.0.0.1]:54826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBRqX-0007Gw-No for submit@debbugs.gnu.org; Tue, 11 Sep 2012 10:53:50 -0400 Original-Received: from mail-wg0-f46.google.com ([74.125.82.46]:52371) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBRqU-0007Go-Rp for 12345@debbugs.gnu.org; Tue, 11 Sep 2012 10:53:47 -0400 Original-Received: by wgi16 with SMTP id 16so422379wgi.15 for <12345@debbugs.gnu.org>; Tue, 11 Sep 2012 07:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=F8i2qEY1Hgfu3b3gK4BPbBFIPr7UWWtpJvz+SgQL3aY=; b=vQolJLGGdJcd3H8BToeYvAjcJ+YMD4scowW2g9imOqutxq4Z8GKrct3DKHwjxsWGAA MxWcjwSnxjiqfJz9rIjVp+81COzwzdF/33IJQI7z2bdBNTLacbOV3gWwadjSZHZYnXSe IkbhW4hU4t3dH3CXUT39BAFJMHhmBz0/abnwcUyDwD43HA8SjTjtVILSeHAowBkbvHIY BWmHN66cPXv7bZ93ISNvV90ZaX0txdQQlLiQEoHBEXG6Kf802i1npXOVr47dYBDrUHAH C5xCiCc0JwT5pKeepQSj1kyKUcKXrhrztnglUAKGxpmJZYT/0K82PqIlUt+qSwTRegID sNmg== Original-Received: by 10.216.138.13 with SMTP id z13mr9960985wei.65.1347375185206; Tue, 11 Sep 2012 07:53:05 -0700 (PDT) Original-Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id bc2sm4457224wib.0.2012.09.11.07.53.03 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 07:53:04 -0700 (PDT) Original-Received: by myhost.localdomain (Postfix, from userid 1000) id 348DA89A2; Tue, 11 Sep 2012 16:53:06 +0200 (CEST) In-Reply-To: (Drew Adams's message of "Tue, 11 Sep 2012 07:24:08 -0700") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64119 Archived-At: Hi Drew, "Drew Adams" writes: > 1. I think any changes in the behavior and bindings should be proposed on > emacs-devel. Personally, I don't care much, but I'm pretty sure that at least > some people will want to keep the `=' binding because `+' is often on a Shift > key. Emacs-devel is also the place to pose your question about zero. Right, I will ask on emacs-devel. > 2. Please consider changing the name of the parameter to INCREMENT, so the doc > string is more readable: "Adjust the height of the default face by INCREMENT." > Say explicitly that INCREMENT defaults to 1. "INC" seems a rather standard and self-explanatory pet name for "INCREMENT". > 3. Alternatively, you could say something like this: > > "Adjust the height of face `default' by N text-scale steps. > N is the numeric prefix agument: positive to increase height, negative > to decrease. Step size is the value of `text-scale-mode-step'." Yes. > 4. Don't be surprised if Stefan doesn't go along with your change to not use the > temporary keymap. He just got through _adding_ such code here and there > throughout Emacs. (Makes no difference to me - my bug report was about the doc > string.) I've nothing against temporary keymaps -- I thought the buggy behavior I've found and reported was the default one, so I just implemented text-scale-adjust another way. Also, I think the (while ... read-event) construct is a simple way to keep the message displayed. But surely more a matter of taste than a technical point.