From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vitalie Spinu Newsgroups: gmane.emacs.devel Subject: Re: fix for bug 10994 breaks ido customizations in major way Date: Tue, 07 May 2013 00:49:24 +0200 Organization: EUR Message-ID: <87txmfyb9n.fsf@gmail.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367880578 7680 80.91.229.3 (6 May 2013 22:49:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 May 2013 22:49:38 +0000 (UTC) Cc: Leo Liu , emacs-devel@gnu.org To: Le Wang Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 00:49:37 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UZUDw-0006ad-0b for ged-emacs-devel@m.gmane.org; Tue, 07 May 2013 00:49:36 +0200 Original-Received: from localhost ([::1]:47016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZUDv-0000Az-ER for ged-emacs-devel@m.gmane.org; Mon, 06 May 2013 18:49:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZUDq-0000At-AF for emacs-devel@gnu.org; Mon, 06 May 2013 18:49:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZUDn-0007mX-OU for emacs-devel@gnu.org; Mon, 06 May 2013 18:49:30 -0400 Original-Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:59858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZUDn-0007mR-Hl for emacs-devel@gnu.org; Mon, 06 May 2013 18:49:27 -0400 Original-Received: by mail-wi0-f176.google.com with SMTP id hq12so3075705wib.3 for ; Mon, 06 May 2013 15:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=29xISfbQZZrG0iavajiRFsgi1eeaWxhwIJz9MBa65T0=; b=PLZveHdtkVdcJG6PJMXM87KAanHonydEq7+OVZb2fqUEUeQjIFEHGW3VYxQYjNJf8Q XxO515atSxeKdS6BRlwbhvBkqL7mhD3Oud5pYVrJNNosujZSZxi7uMeozfh+8XNmKS5m 1uN1Ph/FEbhQI9H/5R1qva0xXUOkGDn9WpvogiS7apo1QH8Xg2p33KHe4l+gaW1hlWc0 6FmPOlKx/c6y6rOwaP6IB1QsR3vwoj7QmNGhYuoxhB6Tse/6d1A/93jfI4p9vnXV07pA p20nxgLZX2sMXgPl/4DeL+D5oZNyZBk2v46R/nn5p7WrWiVX20QWC5B1Ccd54rowV3Vk Nk4g== X-Received: by 10.180.90.70 with SMTP id bu6mr11001853wib.34.1367880566236; Mon, 06 May 2013 15:49:26 -0700 (PDT) Original-Received: from localhost (dhcp-077-249-018-128.chello.nl. [77.249.18.128]) by mx.google.com with ESMTPSA id q18sm16632532wiw.8.2013.05.06.15.49.25 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 06 May 2013 15:49:25 -0700 (PDT) In-Reply-To: (Le Wang's message of "Sat, 4 May 2013 15:00:24 +0800") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159379 Archived-At: >> Le Wang >> on Sat, 4 May 2013 15:00:24 +0800 wrote: > On Sat, May 4, 2013 at 4:33 AM, Leo Liu wrote: >> On 2013-05-03 20:49 +0800, Le Wang wrote: >> > There are a few ido customizations floating around that propertizes text. >> > This will break all of them. I don't think this fix is acceptable. >> What do you mean by "break"? When propertied strings are used, they are used for a reason - to carry additional information. There are plenty of applications that might need same strings but with different meaning. For example ido for tag or imenu navigation, there might be several locations where a symbol is used/defined. Help topics might have same name but be in different files/packages. Same file-names in different directories. Same index entry but different locations, etc. >> That I wouldn't know. I only know what is in emacs and that the fix has >> been in use for a while. Feel free to propose a different fix >> > Sure, I've attached a patch that deletes duplicates. Currently (let ((t1 (propertize "aaa" 'aaa 12)) (t2 (propertize "aaa" 'aaa 11))) (ido-completing-read "?: " (list t1 t2 "sfd"))) works as expected. And the above patch breaks that. Vitalie