From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <schulte.eric@gmail.com>
Subject: Re: [BUG][PATCH] Commit '3142297d69f6063221215757a3ba9c74adcf3e43'
 breaks some my files
Date: Mon, 29 Jul 2013 07:59:28 -0600
Message-ID: <87txjdo49c.fsf@gmail.com>
References: <20130729041726.GA697@smoon>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53872)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1V3o2Q-0001Lq-EA
	for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 10:03:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1V3o2L-0003nK-Tl
	for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 10:03:02 -0400
Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:52552)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1V3o2L-0003n6-N8
	for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 10:02:57 -0400
Received: by mail-pd0-f180.google.com with SMTP id 10so5413524pdi.39
	for <emacs-orgmode@gnu.org>; Mon, 29 Jul 2013 07:02:55 -0700 (PDT)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Vladimir Lomov <lomov.vl@gmail.com>
Cc: General discussions about Org-mode <emacs-orgmode@gnu.org>

Hi Vladimir,

Thanks for mentioning this bug and sending along your trial and error
patch.  It helped me to confirm the location of the bug.  I've just
pushed up a fix.

Best,

Vladimir Lomov <lomov.vl@gmail.com> writes:

> Hello,
> as title states, commit '3142297d69f6063221215757a3ba9c74adcf3e43'
> breaks one of my Org document (I have many but faced with a bug only
> with particular one). In that file tables contain data (three columns,
> one header) which are transformed and tangle to files (xml, txt). Before
> the commit '3142297d69f6063221215757a3ba9c74adcf3e43' all works fine,
> begining with it I can't tangle files with error message
> BEGIN_EXAMPLE
>   mapc: Wrong type argument: consp, nil
> END_EXAMPLE
>
> By means of trial-and-error I made small patch which fixes the problem
> for me. As I'm know very few in Emacs Lisp I'm not sure if my fix is
> correct, so I just added two lines without "proper" reindenting of whole
> block.
>
> BEGIN_EXAMPLE
> diff --git a/lisp/ob-core.el b/lisp/ob-core.el
> index c2722db..013646b 100644
> --- a/lisp/ob-core.el
> +++ b/lisp/ob-core.el
> @@ -2353,6 +2353,7 @@ parameters when merging lists."
>      (setq vars (reverse vars))
>      (while vars (setq params (cons (cons :var (cddr (pop vars))) params)))
>      ;; clear out col-names and row-names for replaced variables
> +    (when (and (consp :colname-names) (consp :rowname-names))
>      (mapc
>       (lambda (name)
>         (mapc
> @@ -2365,6 +2366,7 @@ parameters when merging lists."
>  				  params)))
>  	(list :colname-names :rowname-names)))
>       clearnames)
> +    )
>      (mapc
>       (lambda (hd)
>         (let ((key (intern (concat ":" (symbol-name hd))))
> END_EXAMPLE
>
>
> P.S. I was lazy to prepare MWE. The mentioned document is available at
> https://github.com/vp1981/scripts/blob/master/docs/openbox/rc.org
>
> ---
> WBR, Vladimir Lomov

-- 
Eric Schulte
http://cs.unm.edu/~eschulte