From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] package.el: check tarball signature
Date: Wed, 02 Oct 2013 06:41:28 -0400 [thread overview]
Message-ID: <87txh0uf8n.fsf@flea.lifelogs.com> (raw)
In-Reply-To: 87fvsk9m8b.fsf-ueno@gnu.org
On Wed, 02 Oct 2013 16:16:04 +0900 Daiki Ueno <ueno@gnu.org> wrote:
DU> I've read the discussion and patches, but it's still unclear to me.
DU> Your latest(?) patch (package-archive-signed-3.patch) has
DU> package--create-detached-signature, but nobody calls it. For what
DU> purpose would you need signature generation?
So the maintainer can create a signature from Emacs instead of
externally. The signer is intended to be a maintainer after review, not
a package creator.
DU> Or, perhaps you wanted to develop a user interface to upload tarballs
DU> with signature? Then it should be go into package-x.el instead of
DU> package.el, I suppose.
It's something you would run on the ELPA server, not at upload time.
I thought it belonged nicely in package.el.
DU> Anyway, I'm a bit surprised that there are few researches of existing
DU> packaging systems which already utilize GPG signature, such as Debian
DU> and Fedora. AFAIK, those systems do not require signing operation in
DU> their installer UI.
package.el is not just an installer UI, it's a full package manager.
>> In addition I started on the EPG interaction you've finished, so you can
>> probably start with my patch and fix the EPG-related pieces and any
>> other issues instead of writing your own.
DU> I'm sorry, I couldn't find anything I can reuse in your patch. It even
DU> succeeds signature verification when GPG reports bad signatures.
That's one of the EPG-related pieces I mentioned need fixing. But at
this point your v2 patch has done the work so there's no point in arguing.
DU> Also, why did you choose ".gpgsig" extension rather than ".sig",
DU> which has already been used on ftp.gnu.org for a decade?
I think the extension name is not that important, but here specifically
I wanted to indicate it's generated by GPG. .sig will obviously work
exactly the same way.
DU> And I think it's too much to modify package--with-work-buffer to
DU> check signatures of all files downloaded.
I disagree, but please implement what you believe will do the work of
checking the signatures for packages (tarballs and individual) and the
package index. That's the goal; the implementation details don't
matter too much.
Ted
next prev parent reply other threads:[~2013-10-02 10:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 19:48 [PATCH] package.el: check tarball signature Daiki Ueno
2013-09-30 19:58 ` Eli Zaretskii
2013-10-02 6:20 ` [PATCHv2] " Daiki Ueno
2013-10-02 10:43 ` Ted Zlatanov
2013-09-30 21:54 ` [PATCH] " Ted Zlatanov
2013-09-30 22:56 ` Stefan Monnier
2013-10-02 11:17 ` Ted Zlatanov
2013-10-02 7:16 ` Daiki Ueno
2013-10-02 10:41 ` Ted Zlatanov [this message]
2013-10-02 12:22 ` Daiki Ueno
2013-10-02 13:53 ` Ted Zlatanov
2013-10-03 3:51 ` Stefan Monnier
2013-10-02 13:15 ` Thien-Thi Nguyen
2013-10-03 3:45 ` Stefan Monnier
2013-10-03 3:52 ` Stefan Monnier
2013-10-03 7:18 ` Daiki Ueno
2013-10-03 14:19 ` Ted Zlatanov
2013-10-03 15:01 ` Stefan Monnier
2013-10-04 19:23 ` Eli Zaretskii
2013-10-04 21:14 ` Ted Zlatanov
2013-10-05 0:34 ` Daiki Ueno
2013-10-05 5:40 ` Stephen J. Turnbull
2013-10-05 10:03 ` Ted Zlatanov
2013-10-05 15:07 ` Stephen J. Turnbull
2013-10-05 21:51 ` Ted Zlatanov
2013-10-05 9:57 ` Ted Zlatanov
2013-10-05 7:09 ` Eli Zaretskii
2013-10-05 10:11 ` Ted Zlatanov
2013-10-05 12:37 ` Eli Zaretskii
2013-10-05 13:53 ` Stefan Monnier
2013-10-04 2:46 ` Daiki Ueno
2013-10-04 16:19 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txh0uf8n.fsf@flea.lifelogs.com \
--to=tzz@lifelogs.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.