From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17808: 24.4.50; vc-annotate colors Date: Thu, 03 Jul 2014 02:31:03 +0300 Organization: JURTA Message-ID: <87tx6zwdnk.fsf@mail.jurta.org> References: <87bntpl77v.fsf@mail.jurta.org> <87vbrg8vvo.fsf@mail.jurta.org> <8361jg4gtk.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1404346959 8133 80.91.229.3 (3 Jul 2014 00:22:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Jul 2014 00:22:39 +0000 (UTC) Cc: 17808@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 03 02:22:31 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X2UnF-00057p-OV for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Jul 2014 02:22:29 +0200 Original-Received: from localhost ([::1]:57072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2UnF-0003M9-7W for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Jul 2014 20:22:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2Umz-0003IF-6G for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2014 20:22:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2Ump-0002Eu-Q1 for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2014 20:22:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2Ump-0002Eq-Ma for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2014 20:22:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X2Ump-0003L8-Bo for bug-gnu-emacs@gnu.org; Wed, 02 Jul 2014 20:22:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jul 2014 00:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17808-submit@debbugs.gnu.org id=B17808.140434689812743 (code B ref 17808); Thu, 03 Jul 2014 00:22:03 +0000 Original-Received: (at 17808) by debbugs.gnu.org; 3 Jul 2014 00:21:38 +0000 Original-Received: from localhost ([127.0.0.1]:40871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2UmO-0003JJ-D8 for submit@debbugs.gnu.org; Wed, 02 Jul 2014 20:21:37 -0400 Original-Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:38954 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2UmM-0003J7-Os for 17808@debbugs.gnu.org; Wed, 02 Jul 2014 20:21:35 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id BDA4A30A1CBAA9; Wed, 2 Jul 2014 17:21:32 -0700 (PDT) In-Reply-To: <8361jg4gtk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Jul 2014 05:47:51 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91124 Archived-At: >> > Currently vc-annotate uses dark background even when the default >> > background is light. Would be nicer to have another option similar >> > to the existing `vc-annotate-background' that will define the >> > default foreground (instead of the default background) and put >> > colors from color-map on the background instead of the foreground: >> >> Actually much cleaner would be to add a dedicated user option >> that will define whether to apply the color map to the background >> or to the foreground. When applied to the background with the >> default light background, colors need to be less saturated, >> so the saturation is decreased from 75% to 20% for light backgrounds. >> Also `vc-annotate-background' doesn't need the default value "black" >> because the background will be dark on dark environments anyway. > > Did anyone think of just using the current default background color? > If not, why not? Some colors from the current `vc-annotate-color-map' are illegible when used for a foreground on a light background (white by default). But the last patch provides a palette where color saturation is reduced from 75% to 20%, so the output looks nicely for light backgrounds where related lines are grouped using the same backgrounds like in the table from this post :-) https://plus.google.com/+BrunoOliveira/posts/1mnVJcJqzVD