From: Juri Linkov <juri@jurta.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 17808@debbugs.gnu.org
Subject: bug#17808: 24.4.50; vc-annotate colors
Date: Thu, 03 Jul 2014 02:31:03 +0300 [thread overview]
Message-ID: <87tx6zwdnk.fsf@mail.jurta.org> (raw)
In-Reply-To: <8361jg4gtk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Jul 2014 05:47:51 +0300")
>> > Currently vc-annotate uses dark background even when the default
>> > background is light. Would be nicer to have another option similar
>> > to the existing `vc-annotate-background' that will define the
>> > default foreground (instead of the default background) and put
>> > colors from color-map on the background instead of the foreground:
>>
>> Actually much cleaner would be to add a dedicated user option
>> that will define whether to apply the color map to the background
>> or to the foreground. When applied to the background with the
>> default light background, colors need to be less saturated,
>> so the saturation is decreased from 75% to 20% for light backgrounds.
>> Also `vc-annotate-background' doesn't need the default value "black"
>> because the background will be dark on dark environments anyway.
>
> Did anyone think of just using the current default background color?
> If not, why not?
Some colors from the current `vc-annotate-color-map' are
illegible when used for a foreground on a light background
(white by default).
But the last patch provides a palette where color saturation
is reduced from 75% to 20%, so the output looks nicely
for light backgrounds where related lines are grouped
using the same backgrounds like in the table from this post :-)
https://plus.google.com/+BrunoOliveira/posts/1mnVJcJqzVD
next prev parent reply other threads:[~2014-07-02 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 6:54 bug#17808: 24.4.50; vc-annotate colors Juri Linkov
2014-07-01 23:18 ` Juri Linkov
2014-07-02 2:47 ` Eli Zaretskii
2014-07-02 23:31 ` Juri Linkov [this message]
2014-07-04 23:48 ` Juri Linkov
2014-07-08 8:51 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx6zwdnk.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=17808@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.