all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* seq-group-by returns groups in wrong order?
@ 2015-02-08  1:17 Alexander Baier
  2015-02-08 10:50 ` Nicolas Petton
  2015-02-09 12:21 ` Nicolas Petton
  0 siblings, 2 replies; 5+ messages in thread
From: Alexander Baier @ 2015-02-08  1:17 UTC (permalink / raw)
  To: emacs-devel

Hello,

The groups returned by seq-group-by are reversed, is this intended
behaviour?

(seq-group-by #'oddp [1 2 3 4 5])
;; => ((t 5 3 1) (nil 4 2))

I was expecting ((t 1 3 5) (nil 2 4)) to be returned. This is seq.el
from elpa, version 1.1.

Regards,
-- 
Alexander Baier




^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: seq-group-by returns groups in wrong order?
  2015-02-08  1:17 seq-group-by returns groups in wrong order? Alexander Baier
@ 2015-02-08 10:50 ` Nicolas Petton
  2015-02-09 12:21 ` Nicolas Petton
  1 sibling, 0 replies; 5+ messages in thread
From: Nicolas Petton @ 2015-02-08 10:50 UTC (permalink / raw)
  To: Alexander Baier; +Cc: emacs-devel

Alexander Baier <alexander.baier@mailbox.org> writes:

> Hello,
>
> The groups returned by seq-group-by are reversed, is this intended
> behaviour?
>
> (seq-group-by #'oddp [1 2 3 4 5])
> ;; => ((t 5 3 1) (nil 4 2))
>
> I was expecting ((t 1 3 5) (nil 2 4)) to be returned. This is seq.el
> from elpa, version 1.1.

Indeed, it would be much better. I will fix it as soon as possible.

Cheers,
Nico
-- 
Nicolas Petton
http://nicolas-petton.fr




^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: seq-group-by returns groups in wrong order?
  2015-02-08  1:17 seq-group-by returns groups in wrong order? Alexander Baier
  2015-02-08 10:50 ` Nicolas Petton
@ 2015-02-09 12:21 ` Nicolas Petton
  2015-02-10 20:31   ` Alexander Baier
  1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Petton @ 2015-02-09 12:21 UTC (permalink / raw)
  To: Alexander Baier; +Cc: emacs-devel


Alexander Baier <alexander.baier@mailbox.org> writes:

> Hello,
>
> The groups returned by seq-group-by are reversed, is this intended
> behaviour?
>
> (seq-group-by #'oddp [1 2 3 4 5])
> ;; => ((t 5 3 1) (nil 4 2))
>
> I was expecting ((t 1 3 5) (nil 2 4)) to be returned. This is seq.el
> from elpa, version 1.1.

I updated it both in Emacs master and GNU ELPA, and bumped the version
number to 1.1.1.

Cheers,
Nico
-- 
Nicolas Petton
http://nicolas-petton.fr




^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: seq-group-by returns groups in wrong order?
  2015-02-09 12:21 ` Nicolas Petton
@ 2015-02-10 20:31   ` Alexander Baier
  2015-02-11 13:38     ` Nicolas Petton
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Baier @ 2015-02-10 20:31 UTC (permalink / raw)
  To: emacs-devel

On 2015-02-09 13:21 Nicolas Petton wrote:
> Alexander Baier <alexander.baier@mailbox.org> writes:
>
>> Hello,
>>
>> The groups returned by seq-group-by are reversed, is this intended
>> behaviour?
>>
>> (seq-group-by #'oddp [1 2 3 4 5])
>> ;; => ((t 5 3 1) (nil 4 2))
>>
>> I was expecting ((t 1 3 5) (nil 2 4)) to be returned. This is seq.el
>> from elpa, version 1.1.
>
> I updated it both in Emacs master and GNU ELPA, and bumped the version
> number to 1.1.1.

I just tested the new version and found it only works with lists, but
not with vectors or strings. This seems to be because (seq-)reverse only
operates on lists.

Regards,
-- 
Alexander Baier




^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: seq-group-by returns groups in wrong order?
  2015-02-10 20:31   ` Alexander Baier
@ 2015-02-11 13:38     ` Nicolas Petton
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Petton @ 2015-02-11 13:38 UTC (permalink / raw)
  To: Alexander Baier; +Cc: emacs-devel


Alexander Baier <alexander.baier@mailbox.org> writes:

> On 2015-02-09 13:21 Nicolas Petton wrote:
>> Alexander Baier <alexander.baier@mailbox.org> writes:
>>
>>> Hello,
>>>
>>> The groups returned by seq-group-by are reversed, is this intended
>>> behaviour?
>>>
>>> (seq-group-by #'oddp [1 2 3 4 5])
>>> ;; => ((t 5 3 1) (nil 4 2))
>>>
>>> I was expecting ((t 1 3 5) (nil 2 4)) to be returned. This is seq.el
>>> from elpa, version 1.1.
>>
>> I updated it both in Emacs master and GNU ELPA, and bumped the version
>> number to 1.1.1.
>
> I just tested the new version and found it only works with lists, but
> not with vectors or strings. This seems to be because (seq-)reverse only
> operates on lists.

Yes, I'm adding a backward-compatible version of seq-reverse for
Emacs 24.

Cheers,
Nico
-- 
Nicolas Petton
http://nicolas-petton.fr




^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-11 13:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08  1:17 seq-group-by returns groups in wrong order? Alexander Baier
2015-02-08 10:50 ` Nicolas Petton
2015-02-09 12:21 ` Nicolas Petton
2015-02-10 20:31   ` Alexander Baier
2015-02-11 13:38     ` Nicolas Petton

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.