From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19865: tar-untar-buffer: should honor default-directory Date: Sat, 14 Feb 2015 19:42:42 +0000 Message-ID: <87twyo9t59.fsf@violet.siamics.net> References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> <877fvkbdpw.fsf@violet.siamics.net> <83a90gwfpl.fsf@gnu.org> <873868bbvk.fsf@violet.siamics.net> <8361b4wd8d.fsf@gnu.org> <87y4o09ukb.fsf@violet.siamics.net> <831tlswavg.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1423943003 28590 80.91.229.3 (14 Feb 2015 19:43:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Feb 2015 19:43:23 +0000 (UTC) To: 19865@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 14 20:43:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YMicQ-0005BB-OI for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Feb 2015 20:43:10 +0100 Original-Received: from localhost ([::1]:60960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMicQ-0006O0-9B for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Feb 2015 14:43:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMicN-0006N4-AW for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 14:43:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMicI-0003I2-DR for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 14:43:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMicH-0003Hu-Uq for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 14:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YMicH-0007h7-LU for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 14:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Feb 2015 19:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19865 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19865-submit@debbugs.gnu.org id=B19865.142394297329562 (code B ref 19865); Sat, 14 Feb 2015 19:43:01 +0000 Original-Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 19:42:53 +0000 Original-Received: from localhost ([127.0.0.1]:44190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMic8-0007gj-JY for submit@debbugs.gnu.org; Sat, 14 Feb 2015 14:42:53 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:43855) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMic6-0007gb-MO for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 14:42:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=5m35+2o6k7qdpn+4cLdnFszeZ82Dnu9lBh0kU1MUWI0=; b=XvV81gD70AkwFyOX79TkPbAgvUbi9brDGmxxvFVymR9JSKsS2doOvJT2OQq1rmBzQQCoOxZgmIleWbP6hxD53hQmjKv5y2lxD6oSMQDjO4KxrRYXjX7IbMnAEmYXXdRK3BYgRF3AUyacVS2M4MMhpnezFo+0/gasX3JPQ0+LahQ=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMic5-00053C-VY for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 19:42:50 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMiby-0002za-KW for 19865@debbugs.gnu.org; Sun, 15 Feb 2015 02:42:42 +0700 Mail-Followup-To: 19865@debbugs.gnu.org In-Reply-To: <831tlswavg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 21:28:51 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99414 Archived-At: >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 19:12:04 +0000 >>>> And I=E2=80=99d still like to hear why you think that tar-untar-buffer >>>> /must/ use the value of default-directory local to a buffer >>>> /other/ than the one the user called this command from. >>> Because it's simpler, and makes the code easier to follow. >> My former patch expands the code by a single line; my latter one >> adds two more for a comment (while removing one level of nesting >> from a fair chunk of the code at the same time.) How is that making >> it any harder to follow? > Length of code is only one factor, insignificant in this case. > Subtle dependencies between different parts of the code, as well as > overriding the default-directory value, is what complicates things in > this case. My second patch [1] doesn=E2=80=99t change the value of default-directory (instead, it uses expand-file-name explicitly at the write-region time.) As for the subtle dependencies, could you point at anything specific? TIA. [1] http://debbugs.gnu.org/19865#msg44 [=E2=80=A6] --=20 FSF associate member #7257 np. Povus esti simple =E2=80=94 Persone =E2=80= =A6 B6A0 230E 334A