From: Juri Linkov <juri@linkov.net>
To: Dima Kogan <dima@secretsauce.net>
Cc: 21164@debbugs.gnu.org
Subject: bug#21164: 25.0.50; char-fold search broken for multi-line searches (sometimes)
Date: Sun, 02 Aug 2015 23:40:15 +0300 [thread overview]
Message-ID: <87twshqv9s.fsf@mail.linkov.net> (raw)
In-Reply-To: <87zj2d6keq.fsf@secretsauce.net> (Dima Kogan's message of "Thu, 30 Jul 2015 21:06:05 -0700")
> Hi. I'm using a very recent emacs built from the git HEAD. Sometime in
> the recent past the default C-s behavior was changed to include
> char-folding by default. There's a bug here. Suppose I have a buffer
> containing the following C source.
>
> ----------------------------------------------------
> int a(void)
> {
> for(unsigned long x = 0;
> x < 10;
> x += 2)
> {
> nvm_flash_erase_app_page( x );
> }
> }
>
> int b(void)
> {
> for(unsigned long x = 0;
> x < 10;
> x += 2)
> {
> }
> }
> ----------------------------------------------------
>
>
> Note that the two functions are identical. I place the point at the
> start of one of the 'for' statements, then C-s to enter char-folding
> isearch, then C-w to grab some amount of text to search for. While I'm
> grabbing text that's still on the 'for' line, isearch sees the other
> match, highlights it, and I can jump to it by hitting C-s. However, if I
> hit C-w enough times to go to the next line, the other match is no
> longer seen. This resolves when I turn off char-folding.
Thank you for the bug report. This can be fixed by a small patch:
diff --git a/lisp/character-fold.el b/lisp/character-fold.el
index bf5ae59..db77845 100644
--- a/lisp/character-fold.el
+++ b/lisp/character-fold.el
@@ -123,7 +123,7 @@ (defun character-fold-to-regexp (string &optional lax)
(apply #'concat
(mapcar (lambda (c) (let ((out (or (aref character-fold-table c)
(regexp-quote (string c)))))
- (if (and lax (memq c '(?\s ?\t ?\r ?\n )))
+ (if (memq c '(?\s ?\t ?\r ?\n ))
(concat out "+")
out)))
string))
Later we could also see how to handle both lax-at-the-end-of-the-search-string
and lax-a-sequence-of-whitespace-chars. Maybe something like:
diff --git a/lisp/isearch.el b/lisp/isearch.el
index 8d4bf24..74b7e56 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2613,7 +2613,11 @@ (defun isearch-search-fun-default ()
(length (isearch--state-string
(car isearch-cmds))))))))
(funcall
- (if isearch-forward #'re-search-forward #'re-search-backward)
+ (if (and isearch-lax-whitespace search-whitespace-regexp)
+ (if isearch-forward
+ 're-search-forward-lax-whitespace
+ 're-search-backward-lax-whitespace)
+ (if isearch-forward #'re-search-forward #'re-search-backward))
(if (functionp isearch-word)
(funcall isearch-word string lax)
(word-search-regexp string lax))
next prev parent reply other threads:[~2015-08-02 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 4:06 bug#21164: 25.0.50; char-fold search broken for multi-line searches (sometimes) Dima Kogan
2015-08-02 20:40 ` Juri Linkov [this message]
2015-08-05 17:20 ` Artur Malabarba
2015-08-05 18:16 ` Artur Malabarba
2015-08-05 18:16 ` Artur Malabarba
2015-08-05 18:36 ` Drew Adams
2015-08-05 19:35 ` Artur Malabarba
2015-08-09 9:00 ` Artur Malabarba
2015-08-13 22:46 ` Dima Kogan
2015-08-14 16:39 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twshqv9s.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=21164@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.