From: Stephen Berman <stephen.berman@gmx.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Phillip Lord <phillip.lord@newcastle.ac.uk>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 6e0ffbf 2/3: Stylistic alteration.
Date: Wed, 16 Sep 2015 11:36:06 +0200 [thread overview]
Message-ID: <87twquvh89.fsf@rub.de> (raw)
In-Reply-To: <jwv37yfdrtx.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Tue, 15 Sep 2015 22:25:11 -0400")
On Tue, 15 Sep 2015 22:25:11 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> + if( ! NILP( n ) )
>
> No, that should be
>
> if (! NILP (n))
>
> Again, please take a look at the megabytes of code in src/*.c for examples.
FWIW, a space between `!' and `NILP' is much less common than no space:
steve@rosalinde:~> grep "! NILP" git/emacs/src/*\.c | wc -l
573
steve@rosalinde:~> grep "\!NILP" git/emacs/src/*\.c | wc -l
1481
Steve Berman
next prev parent reply other threads:[~2015-09-16 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150915215948.11475.62011@vcs.savannah.gnu.org>
[not found] ` <E1ZbyGU-00030T-HJ@vcs.savannah.gnu.org>
2015-09-16 2:25 ` [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 6e0ffbf 2/3: Stylistic alteration Stefan Monnier
2015-09-16 9:36 ` Stephen Berman [this message]
2015-09-16 13:23 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twquvh89.fsf@rub.de \
--to=stephen.berman@gmx.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=phillip.lord@newcastle.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.