From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Adding to ELPA? Date: Sat, 10 Oct 2015 09:50:16 +0200 Message-ID: <87twpzgo1z.fsf@fencepost.gnu.org> References: <87si5k3vtt.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444467806 26173 80.91.229.3 (10 Oct 2015 09:03:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 10 Oct 2015 09:03:26 +0000 (UTC) Cc: emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 10 11:03:25 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zkq3n-0006Ac-1a for ged-emacs-devel@m.gmane.org; Sat, 10 Oct 2015 11:03:23 +0200 Original-Received: from localhost ([::1]:44123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zkq3m-0006Xq-7b for ged-emacs-devel@m.gmane.org; Sat, 10 Oct 2015 05:03:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zkq3g-0006Uc-6m for emacs-devel@gnu.org; Sat, 10 Oct 2015 05:03:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zkq3f-0000fu-Ar for emacs-devel@gnu.org; Sat, 10 Oct 2015 05:03:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zkq3e-0000f9-2h; Sat, 10 Oct 2015 05:03:14 -0400 Original-Received: from localhost ([127.0.0.1]:59554 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.82) (envelope-from ) id 1Zkq3b-0004eN-LW; Sat, 10 Oct 2015 05:03:13 -0400 Original-Received: by lola (Postfix, from userid 1000) id 81B3EDF63F; Sat, 10 Oct 2015 09:50:16 +0200 (CEST) In-Reply-To: (Artur Malabarba's message of "Sat, 10 Oct 2015 08:08:25 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191100 Archived-At: Artur Malabarba writes: > On 9 Oct 2015 4:28 pm, "David Kastrup" wrote: >> >> >> Unfortunately, the list server seems to be really, really, slow right >> now. At any rate, would it be the correct way of proceeding to just >> push the following commit to ELPA? Just like that? > > If you've done it before, then yes, pretty much. > If you haven't, showing the patch here (like you just did) is a good idea > to make sure you're doing it right. > > You can also bring it here if you're unsure whether it's GElpa material > (whatever that means). Maybe we should request that people always mention > it here before uploading new packages, just to make sure it's not > replicating an existing one. > > As for your code, I noticed two things. > 1. See other packages for the copyright line used. Ah yes, of course. It would need to be assigned. > 2. You need to depend on cl-lib 0.5 and require it (probably at compile > time). Why? It's autoloaded. The problem is more that I am fuzzy on what Emacs versions to require here if any. Until rather recently, Emacs tended to lose events placed into unread-command-events when they were arriving not one-by-one. With many MIDI input applications (but not necessarily all) that's going to end up a problem. If I require a sufficiently new Emacs version (I don't think any released version suffices), the cl-lib dependency should be a non-issue. -- David Kastrup