From: David Kastrup <dak@gnu.org>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Adding to ELPA?
Date: Sat, 10 Oct 2015 09:50:16 +0200 [thread overview]
Message-ID: <87twpzgo1z.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CAAdUY-JSnHy7ixZ5EoRdbTiPBso9Z8EKF5nwFrRMrwrgH+kHPw@mail.gmail.com> (Artur Malabarba's message of "Sat, 10 Oct 2015 08:08:25 +0100")
Artur Malabarba <bruce.connor.am@gmail.com> writes:
> On 9 Oct 2015 4:28 pm, "David Kastrup" <dak@gnu.org> wrote:
>>
>>
>> Unfortunately, the list server seems to be really, really, slow right
>> now. At any rate, would it be the correct way of proceeding to just
>> push the following commit to ELPA? Just like that?
>
> If you've done it before, then yes, pretty much.
> If you haven't, showing the patch here (like you just did) is a good idea
> to make sure you're doing it right.
>
> You can also bring it here if you're unsure whether it's GElpa material
> (whatever that means). Maybe we should request that people always mention
> it here before uploading new packages, just to make sure it's not
> replicating an existing one.
>
> As for your code, I noticed two things.
> 1. See other packages for the copyright line used.
Ah yes, of course. It would need to be assigned.
> 2. You need to depend on cl-lib 0.5 and require it (probably at compile
> time).
Why? It's autoloaded. The problem is more that I am fuzzy on what
Emacs versions to require here if any. Until rather recently, Emacs
tended to lose events placed into unread-command-events when they were
arriving not one-by-one. With many MIDI input applications (but not
necessarily all) that's going to end up a problem.
If I require a sufficiently new Emacs version (I don't think any
released version suffices), the cl-lib dependency should be a non-issue.
--
David Kastrup
next prev parent reply other threads:[~2015-10-10 7:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 15:28 Adding to ELPA? David Kastrup
2015-10-10 7:08 ` Artur Malabarba
2015-10-10 7:50 ` David Kastrup [this message]
2015-10-10 22:07 ` Artur Malabarba
2015-10-11 16:57 ` David Kastrup
2015-10-11 17:47 ` Artur Malabarba
2015-10-11 18:09 ` David Kastrup
2015-10-11 23:15 ` Artur Malabarba
2015-10-12 5:56 ` David Kastrup
2015-10-12 7:58 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twpzgo1z.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.