From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21747: 25.0.50; while-no-input breaks kbd event handling when called from post-command-hook Date: Mon, 26 Oct 2015 07:57:41 +0100 Message-ID: <87twpem80q.fsf@gnu.org> References: <87bnboemqb.fsf@gnu.org> <838u6sy9s1.fsf@gnu.org> <877fmcejgn.fsf@gnu.org> <83ziz8wrun.fsf@gnu.org> <8737x0egvm.fsf@gnu.org> <83vb9wwnc6.fsf@gnu.org> <874mhg1n25.fsf@gnu.org> <83si50wi2m.fsf@gnu.org> <87fv109yxo.fsf@gnu.org> <83lhasweeh.fsf@gnu.org> <87si4zpg97.fsf@gnu.org> <87oafnpdvh.fsf@gnu.org> <87k2qbpafd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445842705 18541 80.91.229.3 (26 Oct 2015 06:58:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Oct 2015 06:58:25 +0000 (UTC) Cc: bruce.connor.am@gmail.com, 21747@debbugs.gnu.org, storm@cua.dk To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 26 07:58:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZqbjO-0008Nb-MN for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Oct 2015 07:58:10 +0100 Original-Received: from localhost ([::1]:50900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqbjN-0004CG-Rx for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Oct 2015 02:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqbjJ-0004C4-Vr for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2015 02:58:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqbjG-0004Vf-PX for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2015 02:58:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqbjG-0004V9-Lv for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2015 02:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZqbjG-00049R-Bk for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2015 02:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2015 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21747 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21747-submit@debbugs.gnu.org id=B21747.144584267015935 (code B ref 21747); Mon, 26 Oct 2015 06:58:02 +0000 Original-Received: (at 21747) by debbugs.gnu.org; 26 Oct 2015 06:57:50 +0000 Original-Received: from localhost ([127.0.0.1]:38427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zqbj3-00048x-F6 for submit@debbugs.gnu.org; Mon, 26 Oct 2015 02:57:49 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:32978) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zqbj1-00048o-CQ for 21747@debbugs.gnu.org; Mon, 26 Oct 2015 02:57:48 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 39E3A207C5 for <21747@debbugs.gnu.org>; Mon, 26 Oct 2015 02:57:45 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 26 Oct 2015 02:57:45 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=zd3qRZI68yKq2s7EyzUH72lFVtA=; b=LJV2D 873ESsek0jSMG5huGeDPfMHKaNsAZLno/GX2V1hz3xNhzJdvMMevOGU6wQC65V0K 2R+lJfiSeB21iKztmaVYTFqOZ30Wo9zO8icT12K8ARk/bF+UpOkbUBZqy71tS8Xz ARiDezipT8TeLpr/GgiDQhcvOsjIG08edi1vLE= X-Sasl-enc: +zon6FvRJwuyn3wjMzUFaQN7W1uzRGJ6eF3JVBeiaDhV 1445842664 Original-Received: from thinkpad-t440p (unknown [2.162.49.79]) by mail.messagingengine.com (Postfix) with ESMTPA id C7EBA680193; Mon, 26 Oct 2015 02:57:43 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 25 Oct 2015 16:10:26 -0400") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108036 Archived-At: Stefan Monnier writes: >> But I'm really not sure if that's the right thing to do. Maybe it's >> better to fix sh-smie-sh-forward-token so that it doesn't return ";" >> when actually no movement did occur because we already started out at >> EOB. That would be this: > > Sounds right. Ok, great. Then I'll commit that. >> - (let ((semi (sh-smie--newline-semi-p))) >> - (forward-line 1) >> - (if (or semi (eobp)) ";" >> - (sh-smie-sh-forward-token)))) >> + (unless (eobp) >> + (let ((semi (sh-smie--newline-semi-p))) >> + (forward-line 1) >> + (if (or semi (eobp)) ";" >> + (sh-smie-sh-forward-token))))) > > Another option might be to fix sh-smie--newline-semi-p so it returns > nil when at EOB. I haven't looked at the code recently, so I can't > remember if that would be better or not. No, that already returns nil in this scenario where the buffer contents is just "if". When it is called with point being at EOB, it'll scan backwards over the if, and since that's a grammar token with a numeric RIGHT-LEVEL it returns nil anyway. Bye, Tassilo