From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master ef75c3b: Optimize `file-equal-p' and `file-in-directory-p' in Tramp Date: Wed, 11 Nov 2015 16:38:32 +0100 Message-ID: <87twos1r7r.fsf@gmx.de> References: <20151111104737.22161.11802@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447256387 3702 80.91.229.3 (11 Nov 2015 15:39:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Nov 2015 15:39:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 11 16:39:36 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZwXUj-0002To-Qa for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 16:39:33 +0100 Original-Received: from localhost ([::1]:41303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwXUj-00021E-3X for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 10:39:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwXU3-0001Pi-J8 for emacs-devel@gnu.org; Wed, 11 Nov 2015 10:39:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwXTr-0007I0-2S for emacs-devel@gnu.org; Wed, 11 Nov 2015 10:38:51 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:51052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwXTq-0007Gm-Pq for emacs-devel@gnu.org; Wed, 11 Nov 2015 10:38:39 -0500 Original-Received: from detlef.gmx.de ([79.195.12.147]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MM0bQ-1a4Ghz0J3M-007ibU; Wed, 11 Nov 2015 16:38:35 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 11 Nov 2015 09:40:07 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:d/PabZp6sPzwj5TTKpjY8/LSCRdOiVFN7ivwbh5NOUKwRjKs1a4 wLPEYVsganQbBIEMAxvAvLETfZvlruN2j/+p/nPdy6vXeeZWYk3mLUPqDb5hmTJlUGZ6uRf IWs9mIYQkOX/tr8zbJPATBBXblSOxytLxRT72dAe0LH0uAGY9rvJxEUtl4aia5M87xvG94i xUHZl4SVgJWpv6X+A5biw== X-UI-Out-Filterresults: notjunk:1;V01:K0:toSOphf+wCk=:Uf3KrxgLa8YSJDVh9ORykQ U7iUyrCfDBxpOCDQaYntkTC1pl8ktoLWS6/1ymyZA28J9NUCbJBiuEHH+Wxu5ukpbttk2B8Z+ d/pEPaMcEbGaKPgpNzcK+FZ6FodZU4u9/Y6tTXgpHkpRSXIaN3h7z+qJEaTQyPuo/diGp0NUL qheKSBGpckfO+noRZj8KwDMvOjO7A+rUsC8sRhR/P0YDS7UFBqVhll5Irz9vnpfrza+UIXCcZ 9tN8iKOsoIxzQDwlrHyHgDcm62IVKrejcFmlY3ytKqHqEslqyjWZwKxDNk8F5qV3rik96CzHZ iXSx5X00swhj6l7itGpRW+GHQ5jx0EVrTfqTJYxq2nYFe+qC+0D1MGyVNPTAfxjKh4wSfbery Dev4wUrjhQ14lHg/RjEVQstzO1TJy/qcK9xlqwh/WgwD7tPzV8l6iAFrG8ksbA9wqIFWX4kgo WTrIyUwCgh4PQ3/1G+gAmVFDp9yXm2iDaAihFiNT59A0IqXMZXpCXetQXSUYhXr9vIdi5H4jy TGi0ZFGQBhagPPVTc2pZf+HiemosAY3fD3Fo6U4QfK2fEBcWcTDq0mkngCSmUjctREqtGlA1k ozJ6kw8xn9X3PO+LNdBGOs3/r3XbkRyLbM0y7BFFVqJD3fBYYO5HXVfqCJA3wchfcatKc247v wOQErgxouwffUC8EFWlgkzJz/JiUkYoDeyMNaqu7RKlwMCWaAYrO53qT/NC/JuHH/NcHy8IqU Bf1m5QYcUaIP90IbOmM5OcB3XMfERZks0fekl2lv5RAoG4OmSfSLb8iiXW3mh8F+WrbcNxYm X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194071 Archived-At: Stefan Monnier writes: >> + (when (string-equal >> + (file-remote-p (expand-file-name filename1)) >> + (file-remote-p (expand-file-name filename2))) > > The above args to string-equal aren't always strings: why not use > `equal' instead? > (string-equal nil "nil") is non-nil, so I think the code will work > correctly but only because file-remote-p should hopefully never return > "nil". file-remote-p never returns "nil". It returns either the remote prefix of a file name (a string), or nil. > Stefan Best regards, Michael.