From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: character folding future [was: Questions about isearch] Date: Thu, 03 Dec 2015 23:54:27 +0000 Message-ID: <87twnzt7f0.fsf@gmail.com> References: <83lh9lx6oi.fsf@gnu.org> <83a8q1x1cn.fsf@gnu.org> <87h9k74pkw.fsf@gmail.com> <83bnafse4f.fsf@gnu.org> <878u5jrvih.fsf@rub.de> <87mvtyqzyx.fsf@mbork.pl> <831tbaqwwv.fsf@gnu.org> <893eaaa4-6867-4e3f-a926-85f650367d6f@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1449186902 27652 80.91.229.3 (3 Dec 2015 23:55:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Dec 2015 23:55:02 +0000 (UTC) Cc: Eli Zaretskii , Stephen Berman , Richard Stallman , emacs-devel To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 04 00:54:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a4diB-00086c-0k for ged-emacs-devel@m.gmane.org; Fri, 04 Dec 2015 00:54:55 +0100 Original-Received: from localhost ([::1]:37964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4diA-0006Dw-50 for ged-emacs-devel@m.gmane.org; Thu, 03 Dec 2015 18:54:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4dhw-0006CD-If for emacs-devel@gnu.org; Thu, 03 Dec 2015 18:54:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4dhr-0006Sz-JK for emacs-devel@gnu.org; Thu, 03 Dec 2015 18:54:40 -0500 Original-Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:34856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4dhr-0006St-DX; Thu, 03 Dec 2015 18:54:35 -0500 Original-Received: by wmuu63 with SMTP id u63so42130111wmu.0; Thu, 03 Dec 2015 15:54:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=3YJygZx3tIi/R/RY/ZHgwdttkvmABGHC2Rcn6fmALs8=; b=uey/jNGcoXe+9/dSYSJg09HphbTTVjEZm5N7C/Rv5yEYsW6bxkpvbYYIQIEkIL40hL q36yYmaOLhrJnt807G70eWG7umvAmOriuz1sj6mjvvitzKl6Likp7EUge7Z5Wx0l29Hm WsX4Qh7zuQM0twQ09oBPjB7t67nnyU8QiO645xK/uRMODzoRsnnoC2JIHJd64cUkF0A0 bND6VSJxVJCo/gSf/ifJam12vb0jU9o8YXBOWvcf6Ci1lE/nDP/+96cd2IFFsWBvrquI 9kut1yspxTd7JHmoarShKbu0ojn/Fpk/ODWRKe6BygHItW+23ZOFNNeycLh/uIVkUF40 JrVg== X-Received: by 10.28.133.4 with SMTP id h4mr1196313wmd.59.1449186874492; Thu, 03 Dec 2015 15:54:34 -0800 (PST) Original-Received: from Gandalf-Linux.gmail.com (host-78-151-181-156.as13285.net. [78.151.181.156]) by smtp.gmail.com with ESMTPSA id o65sm1115883wmg.3.2015.12.03.15.54.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Dec 2015 15:54:33 -0800 (PST) In-Reply-To: (Drew Adams's message of "Tue, 1 Dec 2015 07:48:56 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195841 Archived-At: Drew Adams writes: > 1. Do you really see that "character-fold-table can take many > seconds to generate"? I don't see that, AFAICT. > > 2. ... No, you're right. I guess I was still carrying my memories from the initial implementations, which did take a few seconds. The current version takes ~0.3 sec on my machine if byte-compiled. While that's far from pleasant (for a lot of people, +0.3 sec of startup time would be noticeable), I guess it's reasonable enough. After all, the user will be warned in the docstring about this caveat. > 5. I think it makes sense in any case to factor out the > code that creates/updates the table (as in my function > `update-char-fold-table'). I agree.