From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22250@debbugs.gnu.org, larsi@gnus.org
Subject: bug#22250: 25.0.50; Eww fails to break RTL paragraph
Date: Mon, 28 Dec 2015 17:40:43 +0100 [thread overview]
Message-ID: <87twn2il10.fsf@justinian.turtle-trading.net> (raw)
In-Reply-To: <83k2nzfdt9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 28 Dec 2015 05:32:34 +0200")
Eli Zaretskii writes:
> Does the patch below fix the problem?
Sorry, no, no change here with that.
I looked at the code though and I noticed the call stack
shr-fill-line
-> shr-vertical-motion
-> vertical-motion
which is used to find the line break point. It seems the idea here is
that Emacs' normal line wrap is used, we just go one line down, and
vertical-motion gets us to the place where Emacs has wrapped. But
Emacs' line wrap is only active with truncate-lines=nil, and
truncate-lines is set to t in eww-mode. When I set truncate-lines=nil
in shr-insert-document the bug does actually go away. I do not know why
truncate-lines was set to t in the first place, though, and where that
may have other consequences.
I'm wondering why this bug depends on RTL layout. I tried my test case
without dir=rtl and with "abc" as text, but that works fine, so RTL
really is a factor.
But that's not right, is it? Conceptually, the linebreak opportunities
should be the same regardless of the paragraph direction, RTL or LTR.
For mixed text the visual order of the runs for should be different for
RTL paragraphs, but even than the length of the lines and where they are
broken should not change. Line breaks should be found according to
logical ordering. Let's say I have:
aaa bbb אאא בבב
If I have to break it before the last word, I want to get:
aaa bbb אאא
בבב
And indeed, fill-paragraph does the right thing with this example.
If I narrow my Emacs window here, it breaks like this, though:
aaa bbb בבב
אאא
So there seems to be an even bigger issue in Emacs generally? At least
Emacs default wrapping behaviour seems not directly usable as a basis
for filling paragraphs correctly.
next prev parent reply other threads:[~2015-12-28 16:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 19:11 bug#22250: 25.0.50; Eww fails to break RTL paragraph Benjamin Riefenstahl
2015-12-27 19:27 ` Eli Zaretskii
2015-12-27 23:09 ` Benjamin Riefenstahl
2015-12-28 3:32 ` Eli Zaretskii
2015-12-28 16:40 ` Benjamin Riefenstahl [this message]
2015-12-28 17:12 ` Eli Zaretskii
2015-12-28 17:49 ` Eli Zaretskii
2015-12-28 18:15 ` Benjamin Riefenstahl
2015-12-28 18:30 ` Eli Zaretskii
2015-12-28 21:23 ` Benjamin Riefenstahl
2015-12-29 16:47 ` Eli Zaretskii
2015-12-29 20:55 ` Benjamin Riefenstahl
2015-12-29 21:03 ` Eli Zaretskii
2015-12-29 22:33 ` Benjamin Riefenstahl
2015-12-30 17:04 ` Eli Zaretskii
2015-12-30 20:22 ` Benjamin Riefenstahl
2015-12-30 20:30 ` Benjamin Riefenstahl
2015-12-31 15:26 ` Eli Zaretskii
2015-12-31 18:10 ` Benjamin Riefenstahl
2015-12-31 18:23 ` Eli Zaretskii
2015-12-30 17:15 ` Eli Zaretskii
2015-12-28 16:46 ` Lars Ingebrigtsen
2015-12-28 19:07 ` Benjamin Riefenstahl
2015-12-28 19:29 ` Eli Zaretskii
2015-12-27 19:30 ` Lars Ingebrigtsen
2015-12-27 19:38 ` Eli Zaretskii
2015-12-27 19:45 ` Eli Zaretskii
2015-12-27 19:49 ` Lars Ingebrigtsen
2015-12-27 20:22 ` Eli Zaretskii
2015-12-27 20:28 ` Eli Zaretskii
2015-12-27 21:00 ` Eli Zaretskii
2015-12-27 21:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twn2il10.fsf@justinian.turtle-trading.net \
--to=b.riefenstahl@turtle-trading.net \
--cc=22250@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.