From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.devel Subject: Re: Is there any particular reason `scroll-other-window' is written in C and not in ELisp? Date: Tue, 29 Dec 2015 18:37:40 +0100 Message-ID: <87twn188bf.fsf@mbork.pl> References: <87y4cd8usv.fsf@mbork.pl> <83oad9dyzj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1451410712 22135 80.91.229.3 (29 Dec 2015 17:38:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Dec 2015 17:38:32 +0000 (UTC) Cc: Emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 29 18:38:23 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDyE3-0004ax-2Q for ged-emacs-devel@m.gmane.org; Tue, 29 Dec 2015 18:38:23 +0100 Original-Received: from localhost ([::1]:49521 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDyE2-00030t-AH for ged-emacs-devel@m.gmane.org; Tue, 29 Dec 2015 12:38:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDyDz-00030o-4T for Emacs-devel@gnu.org; Tue, 29 Dec 2015 12:38:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDyDv-0003mV-V3 for Emacs-devel@gnu.org; Tue, 29 Dec 2015 12:38:19 -0500 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:44620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDyDv-0003mK-Om; Tue, 29 Dec 2015 12:38:15 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 025768F2017; Tue, 29 Dec 2015 18:37:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QXjw7k6jpH7o; Tue, 29 Dec 2015 18:37:46 +0100 (CET) Original-Received: from localhost (unknown [109.232.24.28]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 0C3978F200B; Tue, 29 Dec 2015 18:37:46 +0100 (CET) User-agent: mu4e 0.9.13; emacs 25.0.50.1 In-reply-to: <83oad9dyzj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 195.110.48.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197112 Archived-At: On 2015-12-29, at 17:02, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Date: Tue, 29 Dec 2015 10:32:00 +0100 > > Because it needs to determine the new window-start which is a > window-full above or below the current one, without assuming that all > the lines have the same height in pixels. How do you do that in Lisp? > (The current implementation simulates display.) Interesting, though I know too little about Emacs internals to fully understand your answer. I thought it just does something like (save-excursion (other-buffer) (scroll-up)) Why my (probably na=C3=AFve) implementation won't work? >> The reason I'm asking is that C-M-v (and C-M-S-v, for that matter) do >> the wrong thing if the other window shows a pdf file using pdf-tools. >> If those commands were written in Elisp, I could not only advise them >> (which I can, and probably will), but also propose a patch or >> something. > > Sounds like a bug that should be reported. Not sure if it's in core > Emacs or not, but please do report it with all the necessary details > to whatever the guilty parties are. Not Emacs core, you're right. I'll file a bug report. > Thanks. Thanks --=20 Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University