From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.devel Subject: Re: Enhancing (?) `emacs-version' Date: Wed, 10 Feb 2016 21:53:41 +0100 Message-ID: <87twlg70dm.fsf@mbork.pl> References: <87wpqc75ju.fsf@mbork.pl> <83egck9xmk.fsf@gnu.org> <87vb5w71l1.fsf@mbork.pl> <83a8n89ufo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455137664 23788 80.91.229.3 (10 Feb 2016 20:54:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Feb 2016 20:54:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 10 21:54:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aTbmE-0000GQ-0Q for ged-emacs-devel@m.gmane.org; Wed, 10 Feb 2016 21:54:18 +0100 Original-Received: from localhost ([::1]:43082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTbmD-0001GC-Db for ged-emacs-devel@m.gmane.org; Wed, 10 Feb 2016 15:54:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTblx-0001Fc-Aq for emacs-devel@gnu.org; Wed, 10 Feb 2016 15:54:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTblw-0005nm-AU for emacs-devel@gnu.org; Wed, 10 Feb 2016 15:54:01 -0500 Original-Received: from mail.mojserwer.eu ([2a01:5e00:2:52::8]:56228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTblr-0005if-E3; Wed, 10 Feb 2016 15:53:55 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id C231F9D2002; Wed, 10 Feb 2016 21:53:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 61ybNhlAr2ks; Wed, 10 Feb 2016 21:53:42 +0100 (CET) Original-Received: from localhost (unknown [109.232.24.28]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 5CA009D2001; Wed, 10 Feb 2016 21:53:42 +0100 (CET) User-agent: mu4e 0.9.13; emacs 25.1.50.2 In-reply-to: <83a8n89ufo.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2a01:5e00:2:52::8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199726 Archived-At: On 2016-02-10, at 21:33, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: emacs-devel@gnu.org >> Date: Wed, 10 Feb 2016 21:27:38 +0100 >> >> > We already have the variable emacs-repository-version, and >> > report-emacs-bug already includes it in the report. >> >> Thanks, I had no idea that this exists! What does it state for >> non-development versions (official, prebuilt pretests or binaries, for >> instance)? > > The value is nil then. I guess that it makes sense to include a check for non-nil-ness in emacs-version, and if it passes, include at least the first 6-8 characters of the commit sha. Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University