From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 71783e9: Add the string-numeric-lessp function Date: Mon, 22 Feb 2016 15:00:42 +1100 Message-ID: <87twl1xul1.fsf@gnus.org> References: <20160221043348.25201.81719@vcs.savannah.gnu.org> <87twl2fzaw.fsf@gnus.org> <56CA2C66.7040306@cs.ucla.edu> <87povpzc9c.fsf@gnus.org> <56CA8578.2030004@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456113704 28826 80.91.229.3 (22 Feb 2016 04:01:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Feb 2016 04:01:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 22 05:01:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXhgk-000849-33 for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 05:01:34 +0100 Original-Received: from localhost ([::1]:46743 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXhgg-0002eL-7m for ged-emacs-devel@m.gmane.org; Sun, 21 Feb 2016 23:01:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXhgQ-0002cC-8O for emacs-devel@gnu.org; Sun, 21 Feb 2016 23:01:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXhgN-00009f-1s for emacs-devel@gnu.org; Sun, 21 Feb 2016 23:01:14 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:40063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXhgM-00009T-SK for emacs-devel@gnu.org; Sun, 21 Feb 2016 23:01:10 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aXhfy-0000ux-Al; Mon, 22 Feb 2016 05:00:47 +0100 In-Reply-To: <56CA8578.2030004@cs.ucla.edu> (Paul Eggert's message of "Sun, 21 Feb 2016 19:50:16 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aXhfy-0000ux-Al MailScanner-NULL-Check: 1456718447.23236@xHhFzBSNJ/m4JeVdkIy6cA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200431 Archived-At: Paul Eggert writes: > Not quite sure I'm following. Every string is a version string. I don't think I agree with that. All version strings are strings, though. >> And is this supposed to be this way? >> >> (string-version-lessp "foo001.png" "foo1.png") > > Yes, if the version numbers and everything else result in a tie, it > falls back on straight lexicographic comparison. Having the function > be anything other than a total order would cause problems in sorting > functions that use it to compare. That sounds fine for version numbers, but is not what we want when sorting file names, I think. > Oh, and in response to one of your other questions: this function > should be useful for package versions as well as file names. For > example, I recently updated my libc-bin version on Ubuntu from > 2.21-0ubuntu4 to 2.21-0ubuntu4.1 as part of the getaddrinfo security > update. I don't think that's something our numerical string comparison function should be doing. This version string thing sounds very much geared towards version strings, and that's fine. Using that function for anything else seems increasingly odd. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no