From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Wed, 09 Mar 2016 08:47:05 +0800 Message-ID: <87twkgzddi.fsf@ericabrahamsen.net> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <64a52598-ad53-498c-993c-67d7827dbdfc@default> <838u1uuuau.fsf@gnu.org> <878u1um2xl.fsf@thinkpad.rath.org> <87io0xedoh.fsf@vostro.rath.org> <87fuw179tb.fsf@ericabrahamsen.net> <87pov554vd.fsf@thinkpad.rath.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457484469 16874 80.91.229.3 (9 Mar 2016 00:47:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Mar 2016 00:47:49 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 09 01:47:40 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adSHr-0000qX-9m for ged-emacs-devel@m.gmane.org; Wed, 09 Mar 2016 01:47:39 +0100 Original-Received: from localhost ([::1]:38274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adSHn-000749-Jl for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 19:47:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adSHa-000741-8H for emacs-devel@gnu.org; Tue, 08 Mar 2016 19:47:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adSHV-0005YD-E0 for emacs-devel@gnu.org; Tue, 08 Mar 2016 19:47:22 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:51056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adSHV-0005Y6-7p for emacs-devel@gnu.org; Tue, 08 Mar 2016 19:47:17 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1adSHT-0000YB-7z for emacs-devel@gnu.org; Wed, 09 Mar 2016 01:47:15 +0100 Original-Received: from 111.199.145.15 ([111.199.145.15]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Mar 2016 01:47:15 +0100 Original-Received: from eric by 111.199.145.15 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Mar 2016 01:47:15 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 53 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 111.199.145.15 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:DFbERIX+QtKeBvMW0/tsEudRujY= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201225 Archived-At: Nikolaus Rath writes: > On Mar 08 2016, Eric Abrahamsen wrote: >> Nikolaus Rath writes: >> >>> On Mar 07 2016, Stefan Monnier wrote: >>>>> When I submitted my first Emacs patch, I was astonished when I was asked >>>>> to re-submit with my commit message essentially duplicated in the >>>>> ChangeLog. >>>> >>>> I can't remember ever asking this kind of duplication. We used to >>>> duplicate the ChangeLog-info in the ChangeLog file and in the commit >>>> message (tho we stopped doing it a year ago), but we never asked for it >>>> to be duplicated in the email messages that submits a patch. >>>> >>>> So I have the impression that I'm misunderstanding you. Could you >>>> describe more precisely the kind of duplication you're talking about? >>> >>> No, you understood me correctly. However, I've just looked this up again >>> and it turns out I was actually submitting a patch to Gnus, not >>> Emacs. It was eventually committed by Eric Abrahamsen to the Gnus git >>> repo, who first asked me to re-submit my patch with a commit message >>> that was formatted like a Changelog entry, and to duplicate the message >>> in the ChangeLog itself. It seemed to me that he considered that a >>> questionable practice himself, but said it was obligatory because Gnus >>> closely followed the Emacs standards here. >>> >>> >>> Unfortunately that discussion never made it into the bug >>> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20956), so I'm >>> paraphrasing from memory. But I'm pretty sure I'm remembering correctly, >>> because I was so surprised by this. >> >> Not duplicating it in the email, just commit message + ChangeLog >> duplication. This may be getting conflated with me asking for the commit >> to be emailed as a git-format-patch attachment, which was just because I >> was lazy (and it also preserves the author/committer distinction). > > Actually, I was quite happy about that. I very much prefer if patches > that I submit also have me as the author of the commit. That was my thinking, though as Eli and others point out, it's usually done differently. > (Eric, I think my last email sounded a bit like telling on you. I'm > sorry about that, I think I should have written it differently (or asked > you first). I'm very grateful for the time you took to help me with > those patches, and for patiently explaining the rationale for the > format). No worries, I didn't read it that way! I'm very much not a maintainer, just someone who occasionally patches Gnus when Lars is on vacation, so it's been a learning experience for me, too.