From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#3566: 23.0.94; explain why not to use group defined by define-minor-mode Date: Wed, 27 Apr 2016 22:02:13 +0200 Message-ID: <87twimvn0a.fsf@gnus.org> References: <4276C1AF57E24DE89998752CA7F77EE1@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461787406 9303 80.91.229.3 (27 Apr 2016 20:03:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Apr 2016 20:03:26 +0000 (UTC) Cc: 3566@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 27 22:03:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avVg0-0002Wc-EX for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Apr 2016 22:03:12 +0200 Original-Received: from localhost ([::1]:45132 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avVfz-0007HU-QY for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Apr 2016 16:03:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avVfv-0007Eg-Nw for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2016 16:03:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avVfq-0001Uc-PU for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2016 16:03:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avVfq-0001UY-MV for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2016 16:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1avVfq-0001dM-GV for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2016 16:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Apr 2016 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3566-submit@debbugs.gnu.org id=B3566.14617873396229 (code B ref 3566); Wed, 27 Apr 2016 20:03:02 +0000 Original-Received: (at 3566) by debbugs.gnu.org; 27 Apr 2016 20:02:19 +0000 Original-Received: from localhost ([127.0.0.1]:50646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avVf8-0001cO-U0 for submit@debbugs.gnu.org; Wed, 27 Apr 2016 16:02:19 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:48494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avVf6-0001cG-S1 for 3566@debbugs.gnu.org; Wed, 27 Apr 2016 16:02:17 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avVf3-0002Wu-Eu; Wed, 27 Apr 2016 22:02:15 +0200 In-Reply-To: <4276C1AF57E24DE89998752CA7F77EE1@us.oracle.com> (Drew Adams's message of "Sun, 14 Jun 2009 13:23:10 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116971 Archived-At: "Drew Adams" writes: > In the Elisp manual and in the doc string for define-minor-mode, we > are told not to use the custom group that is automatically defined for > the mode variable, unless we have explicitly used defgroup to define > the group. > > Why? Please provide some explanation. This is the last change to that part: :group GROUP Custom group name to use in all generated `defcustom' forms. Defaults to MODE without the possible trailing \"-mode\". - (This default may not be a valid customization group defined - with `defgroup'. Make sure it is.) + Don't use this default group name unless you have written a + `defgroup' to define that group properly. The previous version may have been clearer? I think what it's trying to say is that if you have a :group, then you should make sure to add a defgroup to that symbol. > Why is it inadvisable to use the same generated group for other > defcustoms without explicitly defining the group? What negative > consequences arise if that is attempted? Please explain in the doc. Presumably this is because there are things in a defgroup that should be there, but aren't if you don't use a defgroup? I.e., :link and a name for the group. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no