From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 3566@debbugs.gnu.org
Subject: bug#3566: 23.0.94; explain why not to use group defined by define-minor-mode
Date: Wed, 27 Apr 2016 22:02:13 +0200 [thread overview]
Message-ID: <87twimvn0a.fsf@gnus.org> (raw)
In-Reply-To: <4276C1AF57E24DE89998752CA7F77EE1@us.oracle.com> (Drew Adams's message of "Sun, 14 Jun 2009 13:23:10 -0700")
"Drew Adams" <drew.adams@oracle.com> writes:
> In the Elisp manual and in the doc string for define-minor-mode, we
> are told not to use the custom group that is automatically defined for
> the mode variable, unless we have explicitly used defgroup to define
> the group.
>
> Why? Please provide some explanation.
This is the last change to that part:
:group GROUP Custom group name to use in all generated `defcustom' forms.
Defaults to MODE without the possible trailing \"-mode\".
- (This default may not be a valid customization group defined
- with `defgroup'. Make sure it is.)
+ Don't use this default group name unless you have written a
+ `defgroup' to define that group properly.
The previous version may have been clearer? I think what it's trying to
say is that if you have a :group, then you should make sure to add a
defgroup to that symbol.
> Why is it inadvisable to use the same generated group for other
> defcustoms without explicitly defining the group? What negative
> consequences arise if that is attempted? Please explain in the doc.
Presumably this is because there are things in a defgroup that should be
there, but aren't if you don't use a defgroup? I.e., :link and a name
for the group.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-04-27 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 20:23 bug#3566: 23.0.94; explain why not to use group defined by define-minor-mode Drew Adams
2011-07-12 14:07 ` Lars Magne Ingebrigtsen
2016-04-27 20:02 ` Lars Ingebrigtsen [this message]
2016-04-27 20:04 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twimvn0a.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=3566@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.