From: Vitalie Spinu <spinuvit@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Patch] hard-widen-limits [was Re: Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.]]
Date: Thu, 28 Apr 2016 15:29:33 +0200 [thread overview]
Message-ID: <87twilq2te.fsf@gmail.com> (raw)
In-Reply-To: <jwvbn66viar.fsf-monnier+Inbox@gnu.org> (Stefan Monnier's message of "Tue, 22 Mar 2016 07:57:27 -0400")
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
>> On Tue, Mar 22 2016 06:57, Stefan Monnier wrote:
> IIRC past discussions on this issue, one option was to merge your
> set-widen-limits into narrow-to-region by adding an optional argument `hard'.
Stefan, adding extra argument turned to be a train wreck. I am afraid, if I
cannot get help on how to extend primitives, I am giving up at this point.
Adding a dummy argument to Fbobp like this:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 770 bytes --]
2 files changed, 3 insertions(+), 3 deletions(-)
src/bytecode.c | 2 +-
src/editfns.c | 4 ++--
modified src/bytecode.c
@@ -1589,7 +1589,7 @@ exec_byte_code (Lisp_Object bytestr, Lisp_Object vector, Lisp_Object maxdepth,
NEXT;
CASE (Bbobp):
- PUSH (Fbobp ());
+ TOP = Fbobp (TOP);
NEXT;
CASE (Bcurrent_buffer):
modified src/editfns.c
@@ -1164,10 +1164,10 @@ At the beginning of the buffer or accessible region, return 0. */)
return temp;
}
-DEFUN ("bobp", Fbobp, Sbobp, 0, 0, 0,
+DEFUN ("bobp", Fbobp, Sbobp, 0, 1, 0,
doc: /* Return t if point is at the beginning of the buffer.
If the buffer is narrowed, this means the beginning of the narrowed part. */)
- (void)
+ (Lisp_Object dummy)
{
if (PT == BEGV)
return Qt;
[-- Attachment #3: Type: text/plain, Size: 1605 bytes --]
then
make extraclean && git clean -f && make bootstrap
gives "Wrong type argument" during byte compilation:
make[3]: Entering directory '/home/vspinu/bin/emacs-test/lisp'
ELC ../lisp/international/eucjp-ms.elc
Reloading stale loaddefs.el
Loading /home/vspinu/bin/emacs-test/lisp/loaddefs.el (source)...
make[3]: Leaving directory '/home/vspinu/bin/emacs-test/lisp'
make -C ../admin/unidata all EMACS="../../src/bootstrap-emacs"
make[3]: Entering directory '/home/vspinu/bin/emacs-test/admin/unidata'
GEN ../../src/macuvs.h
GEN ../../lisp/international/charprop.el
Wrong type argument: char-or-string-p, #<EMACS BUG: INVALID DATATYPE (MISC 0x48ff) Save your buffers immediately and please report this bug>
Makefile:87: recipe for target '../../lisp/international/charprop.el' failed
make[3]: *** [../../lisp/international/charprop.el] Error 255
make[3]: Leaving directory '/home/vspinu/bin/emacs-test/admin/unidata'
Makefile:498: recipe for target '../lisp/international/charprop.el' failed
make[2]: *** [../lisp/international/charprop.el] Error 2
make[2]: Leaving directory '/home/vspinu/bin/emacs-test/src'
Makefile:398: recipe for target 'src' failed
make[1]: *** [src] Error 2
make[1]: Leaving directory '/home/vspinu/bin/emacs-test'
GNUmakefile:79: recipe for target 'bootstrap' failed
I am defining Bbobp, Fbobp, Sbobp just as it's done with any other primitive
with an optional argument. `Fbobp` is never used at C level, so the above diff
is complete and could be run as it is.
Vitalie
next prev parent reply other threads:[~2016-04-28 13:29 UTC|newest]
Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 15:15 bug#22983: syntax-ppss returns wrong result Alan Mackenzie
2016-03-11 20:31 ` Dmitry Gutov
2016-03-11 21:24 ` Alan Mackenzie
2016-03-11 21:35 ` Dmitry Gutov
2016-03-11 22:15 ` Alan Mackenzie
2016-03-11 22:38 ` Dmitry Gutov
2016-03-13 17:37 ` Stefan Monnier
2016-03-13 18:57 ` Alan Mackenzie
2016-03-14 0:47 ` Dmitry Gutov
2016-03-14 1:04 ` Drew Adams
2016-04-03 22:55 ` John Wiegley
2016-03-14 1:49 ` Stefan Monnier
2016-03-14 15:16 ` Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.] Alan Mackenzie
2016-03-14 17:34 ` Andreas Röhler
2016-03-14 20:06 ` Dmitry Gutov
2016-03-19 22:51 ` Vitalie Spinu
2016-03-20 2:19 ` Dmitry Gutov
2016-03-20 12:15 ` Vitalie Spinu
2016-03-20 15:58 ` Dmitry Gutov
2016-03-21 1:05 ` Vitalie Spinu
2016-03-21 3:11 ` Stefan Monnier
2016-03-21 5:05 ` Vitalie Spinu
2016-03-21 7:13 ` Andreas Röhler
2016-03-21 12:26 ` Stefan Monnier
2016-03-21 14:13 ` Vitalie Spinu
2016-03-21 14:43 ` Stefan Monnier
2016-03-21 16:42 ` Vitalie Spinu
2016-03-21 18:31 ` Stefan Monnier
2016-03-21 19:16 ` Vitalie Spinu
2016-03-21 20:47 ` Stefan Monnier
2016-03-21 20:33 ` Alan Mackenzie
2016-03-21 20:49 ` Stefan Monnier
2016-03-21 21:03 ` Drew Adams
2016-03-21 21:12 ` Dmitry Gutov
2016-03-21 16:45 ` Vitalie Spinu
2016-03-21 22:55 ` Dmitry Gutov
2016-03-22 14:51 ` Stefan Monnier
2016-03-22 18:17 ` Vitalie Spinu
2016-03-23 1:18 ` Dmitry Gutov
2016-03-23 13:18 ` Stefan Monnier
2016-03-22 18:26 ` Vitalie Spinu
2016-03-23 2:07 ` Stefan Monnier
2016-03-23 10:56 ` Vitalie Spinu
2016-03-23 11:41 ` Stefan Monnier
2016-03-23 12:39 ` Vitalie Spinu
2016-03-23 13:23 ` Stefan Monnier
2016-03-23 15:28 ` Dmitry Gutov
2016-03-23 21:51 ` Vitalie Spinu
2016-03-24 7:30 ` Andreas Röhler
2016-03-21 11:56 ` Dmitry Gutov
2016-03-21 5:08 ` [Patch] hard-widen-limits [was Re: Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.]] Vitalie Spinu
2016-03-21 12:39 ` Stefan Monnier
2016-03-21 12:54 ` Vitalie Spinu
2016-03-21 14:07 ` Stefan Monnier
2016-03-21 14:14 ` Vitalie Spinu
2016-03-21 14:04 ` Stefan Monnier
2016-03-21 14:33 ` Vitalie Spinu
2016-03-21 14:54 ` Stefan Monnier
2016-03-21 17:16 ` Vitalie Spinu
2016-03-21 18:36 ` Stefan Monnier
2016-03-21 19:18 ` Vitalie Spinu
2016-03-22 3:17 ` Vitalie Spinu
2016-03-22 9:57 ` Vitalie Spinu
2016-03-22 10:05 ` Vitalie Spinu
2016-03-22 11:57 ` Stefan Monnier
2016-03-22 16:28 ` Vitalie Spinu
2016-03-22 16:44 ` Stefan Monnier
2016-03-22 19:36 ` Vitalie Spinu
2016-03-23 2:22 ` Stefan Monnier
2016-03-23 11:41 ` Vitalie Spinu
2016-03-23 12:34 ` Stefan Monnier
2016-03-23 12:41 ` Vitalie Spinu
2016-03-29 21:43 ` Vitalie Spinu
2016-04-22 14:34 ` Dmitry Gutov
2016-04-24 7:22 ` Vitalie Spinu
2016-04-24 7:28 ` Achim Gratz
2016-04-24 11:33 ` Vitalie Spinu
2016-04-24 13:20 ` Andreas Schwab
2016-04-24 16:11 ` Vitalie Spinu
2016-04-24 16:19 ` Andreas Schwab
2016-04-24 16:41 ` Vitalie Spinu
2016-04-24 16:48 ` Andreas Schwab
2016-04-24 18:01 ` Vitalie Spinu
2016-04-24 19:05 ` Andreas Schwab
2016-04-28 13:29 ` Vitalie Spinu [this message]
2016-04-30 14:06 ` Stefan Monnier
2016-03-22 20:08 ` Richard Stallman
2016-03-22 22:45 ` Vitalie Spinu
2016-03-21 11:47 ` Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.] Dmitry Gutov
2016-03-21 12:40 ` Vitalie Spinu
2016-03-21 13:07 ` Dmitry Gutov
2016-03-21 14:20 ` Vitalie Spinu
2016-03-21 14:29 ` Dmitry Gutov
2016-03-21 14:42 ` Vitalie Spinu
2016-03-21 14:56 ` Dmitry Gutov
2016-03-21 16:52 ` Vitalie Spinu
2016-03-21 21:30 ` Dmitry Gutov
2016-04-03 23:34 ` John Wiegley
2016-03-21 14:02 ` Stefan Monnier
2016-03-21 14:31 ` Vitalie Spinu
2016-03-21 15:06 ` Stefan Monnier
2016-03-21 17:15 ` Andreas Röhler
2016-03-13 17:32 ` bug#22983: syntax-ppss returns wrong result Stefan Monnier
2016-03-13 18:52 ` Andreas Röhler
2016-03-13 18:56 ` Dmitry Gutov
2016-03-18 0:49 ` Dmitry Gutov
2016-03-19 12:27 ` Alan Mackenzie
2016-03-19 18:47 ` Dmitry Gutov
2016-03-27 0:51 ` John Wiegley
2016-03-27 1:14 ` Dmitry Gutov
2016-04-03 22:58 ` John Wiegley
2016-04-03 23:15 ` Dmitry Gutov
2017-09-02 13:12 ` Eli Zaretskii
2017-09-02 17:40 ` Alan Mackenzie
2017-09-02 17:53 ` Eli Zaretskii
2017-09-03 20:44 ` John Wiegley
2017-09-04 23:34 ` Dmitry Gutov
2017-09-05 6:57 ` Andreas Röhler
2017-09-05 12:28 ` John Wiegley
2017-09-07 20:45 ` Alan Mackenzie
2017-09-08 16:04 ` Andreas Röhler
2017-09-10 18:26 ` Alan Mackenzie
2017-09-09 9:44 ` Dmitry Gutov
2017-09-09 10:20 ` Alan Mackenzie
2017-09-09 12:18 ` Dmitry Gutov
2017-09-10 11:42 ` Alan Mackenzie
2017-09-10 11:36 ` bug#22983: [ Patch ] " Alan Mackenzie
2017-09-10 22:53 ` Stefan Monnier
2017-09-10 23:36 ` Dmitry Gutov
2017-09-11 11:10 ` Stefan Monnier
2017-09-12 0:11 ` Dmitry Gutov
2017-09-12 22:12 ` Richard Stallman
2017-09-11 19:42 ` Alan Mackenzie
2017-09-11 20:20 ` Stefan Monnier
2017-09-11 0:11 ` Dmitry Gutov
2017-09-11 20:12 ` Alan Mackenzie
2017-09-12 0:24 ` Dmitry Gutov
2017-09-17 10:29 ` Alan Mackenzie
2017-09-17 23:43 ` Dmitry Gutov
2017-09-18 19:08 ` Alan Mackenzie
2017-09-19 0:02 ` Dmitry Gutov
2017-09-19 20:47 ` Alan Mackenzie
2017-09-22 14:09 ` Dmitry Gutov
2017-09-24 11:26 ` Alan Mackenzie
2017-09-25 23:53 ` Dmitry Gutov
2017-10-01 16:36 ` Alan Mackenzie
2017-10-04 20:07 ` Johan Bockgård
2017-09-17 11:12 ` Philipp Stephani
2017-09-19 20:50 ` Alan Mackenzie
2017-09-07 17:56 ` Alan Mackenzie
2017-09-07 20:36 ` Dmitry Gutov
2016-03-19 23:16 ` Vitalie Spinu
2016-03-19 23:00 ` Vitalie Spinu
2016-03-19 23:20 ` Dmitry Gutov
[not found] ` <mailman.7307.1457709188.843.bug-gnu-emacs@gnu.org>
2017-10-01 16:31 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twilq2te.fsf@gmail.com \
--to=spinuvit@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.