From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#18369: 24.4.50; interactive spec of `facemenu-add-face' Date: Sat, 30 Apr 2016 15:52:07 +0200 Message-ID: <87twijqk54.fsf@gnus.org> References: <62d59397-d3d8-474c-aced-78018b70e6e8@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462024424 30314 80.91.229.3 (30 Apr 2016 13:53:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Apr 2016 13:53:44 +0000 (UTC) Cc: 18369@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 30 15:53:33 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awVKu-0001bS-9y for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2016 15:53:32 +0200 Original-Received: from localhost ([::1]:58491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awVKn-0006gD-5r for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2016 09:53:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awVKe-0006TC-V6 for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 09:53:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awVKT-0002lD-72 for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 09:53:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awVKT-0002kI-3L for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 09:53:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awVKP-00010e-L8 for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 09:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Apr 2016 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18369 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18369-submit@debbugs.gnu.org id=B18369.14620243313817 (code B ref 18369); Sat, 30 Apr 2016 13:53:01 +0000 Original-Received: (at 18369) by debbugs.gnu.org; 30 Apr 2016 13:52:11 +0000 Original-Received: from localhost ([127.0.0.1]:56519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awVJb-0000zV-BP for submit@debbugs.gnu.org; Sat, 30 Apr 2016 09:52:11 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:56806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awVJZ-0000zM-QP for 18369@debbugs.gnu.org; Sat, 30 Apr 2016 09:52:10 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awVJX-0002rY-A7; Sat, 30 Apr 2016 15:52:09 +0200 In-Reply-To: <62d59397-d3d8-474c-aced-78018b70e6e8@default> (Drew Adams's message of "Sat, 30 Aug 2014 22:06:11 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117329 Archived-At: Drew Adams writes: > The interactive use of this command is not as convenient as it could be. > Is there a good reason for this? > > Why does the interactive spec use "*xFace: \nr" (reading a sexp, no > completion etc.)? Why does it not use `read-face-name', as does > `facemenu-set-face' (which calls `facemenu-add-face')? I find these functions odd. `facemenu-set-face' just does this: (facemenu-add-new-face face) (facemenu-add-face face start end) after reading a face name with `read-face-name'. So it's a very thin shim over `facemenu-add-face'. `M-x facemenu-add-face RET foo RET' and nothing happened. Then I did `M-x facemenu-add-face RET bold RET', and it errored out saying Invalid face reference: foo Huh? I have no idea what these two functions are supposed to be doing, but I don't think... they are doing... whatever they should be doing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no