From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Date: Sun, 17 Jul 2016 23:00:33 -0400 Message-ID: <87twfnd50u.fsf@users.sourceforge.net> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1468810890 29518 80.91.229.3 (18 Jul 2016 03:01:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2016 03:01:30 +0000 (UTC) Cc: 23648@debbugs.gnu.org To: Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 18 05:01:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bOyo2-0007ak-R9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 05:01:19 +0200 Original-Received: from localhost ([::1]:44028 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOyo1-0003XJ-Rz for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jul 2016 23:01:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOyns-0003X1-Pt for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 23:01:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOynm-0006Xm-Rz for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 23:01:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOynm-0006Xi-P7 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 23:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bOynm-0006Zt-GB for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 23:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 03:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146881084125247 (code B ref 23648); Mon, 18 Jul 2016 03:01:02 +0000 Original-Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 03:00:41 +0000 Original-Received: from localhost ([127.0.0.1]:54969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOynQ-0006Z8-U7 for submit@debbugs.gnu.org; Sun, 17 Jul 2016 23:00:41 -0400 Original-Received: from mail-io0-f180.google.com ([209.85.223.180]:32945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOynP-0006Yv-Dh for 23648@debbugs.gnu.org; Sun, 17 Jul 2016 23:00:39 -0400 Original-Received: by mail-io0-f180.google.com with SMTP id 38so149014453iol.0 for <23648@debbugs.gnu.org>; Sun, 17 Jul 2016 20:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=L3sP6ZRNl4hNqEBEgbHLYv+uKzNPe6W/xNQa1bdDNGk=; b=fCnW+iUPSRuDZM+vdZC6zHp2tFWuwah9yi5JSXc8Um+84o1jehcJUShgTJQpjZTPHu CKVNdigJRT/EK0tj15rcba1t62+2Dt13jHfjJopeOPnlp/gfUUGCeDGi7kbxQCcoD0fa 9OZf4Ql2AeG3q3So7Au92MAG/ZTm9DdX/fiqxFi+6K3+Qqz2EWRKqKlA4ak7f3TAenEo YLIFfSmwPnkerkfbmhGFLZdsE8c/cOe6QxJQoP3DIjSbwjgc5kVUXdW2Bgy9uCyBqTSt NILvJapo1tCIxAK055T/jsoAd1d7aUZBEDjVv7bIqSqr4D+gWJ0OxLCndaPH7+ZvfHqU 6G5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=L3sP6ZRNl4hNqEBEgbHLYv+uKzNPe6W/xNQa1bdDNGk=; b=eVjtbkno29cMzn8b1HAv0rU8185ZF5jz5sldgt43zMlECj/YIC5UWZ0S2EDltCoXZl 4HbSoqn95h/+GTrg2TocHB4KQz1di1o+w/Kainkl42GnArfLhsEvZ02LcHXLpZ3H/Anq R++kmr85gh6lskQudoOp0IhdZlQdXlPeEa5NRDmKtYCtdTLx/zuEyGgfdnNvcPQCl4zo iILo9LgWOA9qW+cg3QiffeXSqA996ngJSskZykekUtEaRtPZDuKa1p2BZYnq1aeYKd7c rf6AFatOM/rhwoG1OeAZQ7DVNuGa+Ofl+C/U6RJfThz3SKl0AgRxQXvxKZ4vjWuC9DhO N+sg== X-Gm-Message-State: ALyK8tIk43N5nCsdtxcEbz84HQ8nHtOQWpx84MuUcyRkowJYa2y9jbcA2+ntyWtKhaL9+g== X-Received: by 10.107.197.134 with SMTP id v128mr30125397iof.178.1468810833709; Sun, 17 Jul 2016 20:00:33 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id w192sm8074162iof.24.2016.07.17.20.00.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Jul 2016 20:00:33 -0700 (PDT) In-Reply-To: (Paul Pogonyshev's message of "Sun, 29 May 2016 16:11:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121205 Archived-At: Paul Pogonyshev writes: > I quite often get the following messages: > > Warning: Unknown defun property =E2=80=98compiler-macro=E2=80=99 in ... > > As far as I could trace it, the problem is indirectly caused by > `define-inline'. While definition of `defun-declarations-alist' does > contain `compiler-macro' in its init form, it can be removed later. > E.g. when I evaluated the variable, it was not there anymore, only > `gv-setter' was there. > > It seems this is done unintentionally by `elisp-completion-at-point': > > (`declare > (list t (mapcar (lambda (x) (symbol-name (car x))) > (delete-dups > ;; FIXME: We should include some > ;; docstring with each entry. > (append > macro-declarations-alist > defun-declarations-alist))))) > > Here `delete-dups' destructively modifies a list that includes > `defun-declarations-alist' as its tail verbatim, not as a copy. > Attached patch should fix that. I agree with analysis and patch here. Since this just appends another nil, it should be safe for emacs-25, right? > > Paul > > * elisp-mode.el (elisp-completion-at-point): Fix to not alter > `defun-declarations-alist' by side effect. > - (append > - macro-declarations-alist > - defun-declarations-alist))))) > + (append macro-declarations-alist > + defun-declarations-alist > + nil)))))