bug#14687: 24.3.50; Minor problem in files.el

bug#14687: 24.3.50; Minor problem in files.el

[Xue Fuqiao]

severity minor

In files.el:
  (defcustom version-control nil
  [...]
  :group 'backup
  :group 'vc)

I don't think this variable is related to VC, so can the last `:group'
keyword be deleted?

In GNU Emacs 24.3.50.1 (x86_64-apple-darwin12.4.0, NS apple-appkit-1187.39)
 of 2013-06-22 on xfq.local
Bzr revision: 113128 dgutov@yandex.ru-20130621230749-qfs0a7kd6vc7338i
Configured using:
 `configure --with-ns --enable-gtk-deprecation-warnings
 --enable-checking'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

--
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/

bug#14687: 24.3.50; Minor problem in files.el

[Glenn Morris]

>   :group 'vc)
>
> I don't think this variable is related to VC, so can the last `:group'
> keyword be deleted?

Fine by me.

(Could you use more descriptive subjects for your future bug reports?
Eg "incorrect custom group for version-control option".)

bug#14687: 24.3.50; Minor problem in files.el

[npostavs]

tags 14687 fixed
close 14687 25.2
quit

Glenn Morris <rgm@gnu.org> writes:

>>   :group 'vc)
>>
>> I don't think this variable is related to VC, so can the last `:group'
>> keyword be deleted?
>
> Fine by me.

git show gnu/master
commit f50e641548672b3332d8dcbc705d7fe3962c7bb2
Author: Noam Postavsky <npostavs@gmail.com>
Date:   Fri Aug 5 20:04:17 2016 -0400

    * lisp/files.el (version-control): Drop :group vc (Bug #14687)

diff --git a/lisp/files.el b/lisp/files.el
index 55a7afe..4d27ef1 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -277,8 +277,7 @@ version-control
   :type '(choice (const :tag "Never" never)
 		 (const :tag "If existing" nil)
 		 (other :tag "Always" t))
-  :group 'backup
-  :group 'vc)
+  :group 'backup)
 (put 'version-control 'safe-local-variable
      (lambda (x) (or (booleanp x) (equal x 'never))))