From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25049: ibuffer bug when saving existing filter, with patches Date: Wed, 30 Nov 2016 09:07:13 -0500 Message-ID: <87twapgiy6.fsf@users.sourceforge.net> References: <8737ianx4s.fsf@gmail.com> <8737i9etj1.fsf@gmail.com> <87d1hd8n6q.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1480514838 5261 195.159.176.226 (30 Nov 2016 14:07:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2016 14:07:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Christopher Genovese , 25049@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 15:07:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC5XS-0000Qm-AT for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 15:07:10 +0100 Original-Received: from localhost ([::1]:44353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC5XW-0001Ej-2j for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 09:07:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC5XQ-0001DD-14 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 09:07:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC5XK-0006qC-6M for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 09:07:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59921) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cC5XK-0006q4-2R for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 09:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cC5XJ-0007Ia-Pr for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 09:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2016 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25049 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25049-submit@debbugs.gnu.org id=B25049.148051478528013 (code B ref 25049); Wed, 30 Nov 2016 14:07:01 +0000 Original-Received: (at 25049) by debbugs.gnu.org; 30 Nov 2016 14:06:25 +0000 Original-Received: from localhost ([127.0.0.1]:47087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC5Wi-0007Hk-UY for submit@debbugs.gnu.org; Wed, 30 Nov 2016 09:06:25 -0500 Original-Received: from mail-io0-f178.google.com ([209.85.223.178]:35691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC5Wh-0007HY-2B for 25049@debbugs.gnu.org; Wed, 30 Nov 2016 09:06:23 -0500 Original-Received: by mail-io0-f178.google.com with SMTP id a124so349589242ioe.2 for <25049@debbugs.gnu.org>; Wed, 30 Nov 2016 06:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2IX+mfo7JNhdhbA4winTd1zoJ2KkRzBQv2cqW2JbyaE=; b=OLwAPjVkET/NrkqfsYQyyFb+1ZyxhVsfdlrTZp3Fc6SvwaVo34KL4J7W1r2P8+kUJ+ Q0LxZeXJBVWHkpiuRvfBADZWhqYpPhhMul6l0Z/8YgVPw4wnnC4oDIiRQkL6XmHwX/gk jcBljQbuz+hhgEHrn3p6o2Niq3XxN8/cycxj1671lHKUeTuNDn3NP3D05cv+7BW27jAV km+a2JHc5hWCCm3ZLAXCwibWseAlmyb1CZvtvbZcrmeLg+3bx0t+ev+XdcG1RbisPA60 JXltH09XSA4jTbayKPBFfBywWm7ZGCYd+9vNMCOIoVhaFaMww+RoUuKjLZvQGj6vPvnA +iJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=2IX+mfo7JNhdhbA4winTd1zoJ2KkRzBQv2cqW2JbyaE=; b=Ii7FFtUxTJrNK4SLG3ZjNrrRFu0PaE0GXrCe2kFDqzxRwSOOLuWNbHXHR3piYeldwr XYSNDt9OQwIi18Lk/cZ1TCx8w1TJ19tuXjb+w8zabruVObVRUs3j2IGYE9TvOF03lc8f vRL8HQxcoGHtmDtFu7EFXEmUwuB+yRaJE25kKgBFjnJ/QCYglmJHOnc7V7XeaVegFeNc RIVRZbb0H6HzP/cgoYp3LsU6ipcjaJqXiBZkw2hMj99VA7FOc1RJpXyQ0kxuclbAv7fz EDTl+Sxtrb/j3e5fWTGRaulbiVs9zm/lRKAylF5/pI6kOWkpmZqTvEO3skrjxgKuvqeR nggQ== X-Gm-Message-State: AKaTC00LrLVEsRfa+3N/92rxEbnJSda31CDrt2/CB6HAcoHym3yHOWzbWAc8PDZfC9j6gg== X-Received: by 10.36.90.80 with SMTP id v77mr28739529ita.73.1480514777274; Wed, 30 Nov 2016 06:06:17 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id l3sm2689908iti.3.2016.11.30.06.06.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Nov 2016 06:06:16 -0800 (PST) In-Reply-To: <87d1hd8n6q.fsf@gmail.com> (Tino Calancha's message of "Wed, 30 Nov 2016 16:02:53 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126303 Archived-At: Tino Calancha writes: > Christopher Genovese writes: > >> I've attached a modified patch file that includes >> all your suggested changes. I did some squashing >> and editing, so this patch has the same three parts >> as before, with properly formatted Change Logs in >> each. You don't need the "Change Log: 2016-11-27 Christopher R. Genovese " part, that information is extracted automatically from the commit metadata. > Thank you very much fr your prompt replay! > > I) > + 'follow-link t > + 'help-echo "Click or RET: save new value in customize" > + 'action (lambda (b) > + (if (not (fboundp 'customize-save-variable)) > + (message "Customize not available; value not saved") > + (customize-save-variable 'ibuffer-saved-filters > + ibuffer-saved-filters) > + (message "Saved updated ibuffer-saved-filters.")))) > The lambda form above doesn't use its 'b' argument, so i have dropped > it. By "drop" I hope you meant "replaced it with `_'". The action function receives 1 argument, so it has to accept it. > > If we don't get further comments to address in 1 week, then let's > push this fix to the master branch. I don't really agree with this switching *Warnings* to help-mode. First, it's out of place for a particular warning to start manipulating the *Warnings* buffer like that. And second, it would make more sense to have a warnings-mode, that could provide more specialized bindings (e.g., ignore warning at point). But that's a subject for another thread. I don't think this patch should do anything about it.