From: npostavs@users.sourceforge.net
To: Tino Calancha <tino.calancha@gmail.com>
Cc: Christopher Genovese <genovese@cmu.edu>, 25049@debbugs.gnu.org
Subject: bug#25049: ibuffer bug when saving existing filter, with patches
Date: Wed, 30 Nov 2016 09:07:13 -0500 [thread overview]
Message-ID: <87twapgiy6.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87d1hd8n6q.fsf@gmail.com> (Tino Calancha's message of "Wed, 30 Nov 2016 16:02:53 +0900")
Tino Calancha <tino.calancha@gmail.com> writes:
> Christopher Genovese <genovese@cmu.edu> writes:
>
>> I've attached a modified patch file that includes
>> all your suggested changes. I did some squashing
>> and editing, so this patch has the same three parts
>> as before, with properly formatted Change Logs in
>> each.
You don't need the "Change Log: 2016-11-27 Christopher R. Genovese
<genovese@cmu.edu>" part, that information is extracted automatically
from the commit metadata.
> Thank you very much fr your prompt replay!
>
> I)
> + 'follow-link t
> + 'help-echo "Click or RET: save new value in customize"
> + 'action (lambda (b)
> + (if (not (fboundp 'customize-save-variable))
> + (message "Customize not available; value not saved")
> + (customize-save-variable 'ibuffer-saved-filters
> + ibuffer-saved-filters)
> + (message "Saved updated ibuffer-saved-filters."))))
> The lambda form above doesn't use its 'b' argument, so i have dropped
> it.
By "drop" I hope you meant "replaced it with `_'". The action function
receives 1 argument, so it has to accept it.
>
> If we don't get further comments to address in 1 week, then let's
> push this fix to the master branch.
I don't really agree with this switching *Warnings* to help-mode.
First, it's out of place for a particular warning to start manipulating
the *Warnings* buffer like that. And second, it would make more sense
to have a warnings-mode, that could provide more specialized bindings
(e.g., ignore warning at point). But that's a subject for another
thread. I don't think this patch should do anything about it.
next prev parent reply other threads:[~2016-11-30 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 6:54 bug#25049: ibuffer bug when saving existing filter, with patches Christopher Genovese
2016-11-29 15:06 ` Tino Calancha
2016-11-29 16:09 ` Christopher Genovese
2016-11-29 23:49 ` Tino Calancha
2016-11-30 5:14 ` Christopher Genovese
2016-11-30 7:02 ` Tino Calancha
2016-11-30 14:07 ` npostavs [this message]
2016-11-30 15:03 ` Tino Calancha
2016-11-30 15:11 ` Tino Calancha
2016-11-30 16:31 ` Christopher Genovese
2016-12-01 2:52 ` Tino Calancha
2016-12-07 10:56 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twapgiy6.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25049@debbugs.gnu.org \
--cc=genovese@cmu.edu \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.