From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore Date: Thu, 22 Dec 2016 19:03:53 -0500 Message-ID: <87tw9va4uu.fsf@users.sourceforge.net> References: <8760mr26dr.fsf@openmailbox.org> <87eg13b4jk.fsf@users.sourceforge.net> <878tr9c4bn.fsf@users.sourceforge.net> <8760mcbta2.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1482451391 24344 195.159.176.226 (23 Dec 2016 00:03:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Dec 2016 00:03:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Mark Karpov , 25157@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 23 01:03:07 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKDKF-0005ga-7m for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 01:03:07 +0100 Original-Received: from localhost ([::1]:36708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKDKJ-0007rE-M4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Dec 2016 19:03:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKDKD-0007qy-MX for bug-gnu-emacs@gnu.org; Thu, 22 Dec 2016 19:03:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKDKA-0005JU-Je for bug-gnu-emacs@gnu.org; Thu, 22 Dec 2016 19:03:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36541) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKDKA-0005JN-GJ for bug-gnu-emacs@gnu.org; Thu, 22 Dec 2016 19:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKDKA-0002rI-82 for bug-gnu-emacs@gnu.org; Thu, 22 Dec 2016 19:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Dec 2016 00:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 25157-submit@debbugs.gnu.org id=B25157.148245138110981 (code B ref 25157); Fri, 23 Dec 2016 00:03:02 +0000 Original-Received: (at 25157) by debbugs.gnu.org; 23 Dec 2016 00:03:01 +0000 Original-Received: from localhost ([127.0.0.1]:51940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKDK9-0002r3-8c for submit@debbugs.gnu.org; Thu, 22 Dec 2016 19:03:01 -0500 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:35592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKDK6-0002qp-Rc for 25157@debbugs.gnu.org; Thu, 22 Dec 2016 19:02:59 -0500 Original-Received: by mail-it0-f42.google.com with SMTP id c20so133533205itb.0 for <25157@debbugs.gnu.org>; Thu, 22 Dec 2016 16:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=acq3Zfxi4TghvHtUM9LDU94hz9YB+VuGAo9DwEScgwY=; b=aaSxK8GRmeZWmnExwhGiwV3IDqATLCUkSHbnQxY5/Oopq8g3+THe+DHeY1or/Dqt4S Q2+7c0khtFxJtxPgPeDZC/MXhxN0k9xjuFn2bxEj74HYO/k04/FoNp+iWWbhh07CmHvO jSs1uGacKkyw2u4MbhaQ1NaDUtObfmqcKJx3YgbD5mG5uQXAqRn4wuQR4ZGnqXAsDF3s 1W3QXd9InhAasykcF2NF/fcpnj+7AtXu3eykgSApzPDuqfRp524qE64/TeKF2SQYPiKc X/hLSgOQu2yogS5a7EVBamqE2+UCWachzIHhynxg97Oea1A/1c/WjTQCUgPvRdHsNdkF G5ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=acq3Zfxi4TghvHtUM9LDU94hz9YB+VuGAo9DwEScgwY=; b=kdsNZyPVueOr1UO3MxMfKN5f14i8pFu5UthlPCr0jz/1oktIlILYJgtIH5KJKNLjPU e8ZudZx4JC8r+9k9v7sE9iI9elPRCcYYoDyByTCYrOsVWeiuZDW6SDwHFxQq8afH+lL4 pfO8MhgIZYSTTjwZUOy1j4NNxi0gmXV18pppwhJeTxGOC/dJmLpP57hBTh9P3y8sOraA AtNHyEM/VaYk8O9Dk4IK2RZbKbefUGRCc4BSrbzIF/t1ag5b6aLDFYUCozh/uigNLeMG ueh8Rvn07d9gslGNonFfOeBB9S8LsqPaxnKyqaIERXp/6Vr5BzSBsUBAuAz33V+6t0fh ZNEg== X-Gm-Message-State: AIkVDXJbSXlUMwJlOiq1RtmXkP5MOTClZiNeVJlvB/Vf3xcsJCvpsv5zP43dweBeXnAteg== X-Received: by 10.36.53.211 with SMTP id k202mr14621092ita.72.1482451373312; Thu, 22 Dec 2016 16:02:53 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id j143sm11451821ita.1.2016.12.22.16.02.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Dec 2016 16:02:52 -0800 (PST) In-Reply-To: (Reuben Thomas's message of "Thu, 22 Dec 2016 12:53:37 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127345 Archived-At: Reuben Thomas writes: > On Dec 22, 2016 2:17 AM, wrote: >> > >> > The only thing I'd change in your match is, as in mine, remove the FIX= ME after save-match-data.=E2=80=8B >> >> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data >> is the call of re-search-forward. >> >> I'm not sure this is a sufficient explanation of why save-match-data is >> needed. Usually in Emacs the caller is responsible for saving the match >> data, if it needs to. I don't really see the need here. > > Can it be removed then? Probably yes. > The only perhaps unexpected thing I can think of is that whitespace-clean= up can be called from a hook, such as save-file-hook, but that > doesn't seem to matter.