From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#25105: 26.0.50; diff navigation is broken Date: Thu, 05 Jan 2017 17:20:47 -0800 Message-ID: <87tw9dc7bk.fsf@secretsauce.net> References: <87inpt6lce.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1483665680 27481 195.159.176.226 (6 Jan 2017 01:21:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Jan 2017 01:21:20 +0000 (UTC) User-Agent: mu4e 0.9.17; emacs 26.0.50.1 Cc: Mark Oteiza , 25105@debbugs.gnu.org, npostavs@users.sourceforge.net, Dmitry Gutov To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 06 02:21:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPJDQ-0005fj-4L for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jan 2017 02:21:08 +0100 Original-Received: from localhost ([::1]:49562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPJDT-0006Yf-TJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jan 2017 20:21:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPJDN-0006YH-Q7 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 20:21:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPJDK-0006fI-Kh for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 20:21:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56995) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPJDK-0006fD-C7 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 20:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPJDK-0003NT-3S for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 20:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2017 01:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25105-submit@debbugs.gnu.org id=B25105.148366565112940 (code B ref 25105); Fri, 06 Jan 2017 01:21:02 +0000 Original-Received: (at 25105) by debbugs.gnu.org; 6 Jan 2017 01:20:51 +0000 Original-Received: from localhost ([127.0.0.1]:44161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPJD9-0003Me-5j for submit@debbugs.gnu.org; Thu, 05 Jan 2017 20:20:51 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPJD7-0003MW-T5 for 25105@debbugs.gnu.org; Thu, 05 Jan 2017 20:20:50 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 398B020CAA; Thu, 5 Jan 2017 20:20:49 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 05 Jan 2017 20:20:49 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=M8TA+FOiFb2/wzeFcFG/DT5nvzc=; b=FeePz+ g4WQlcdDe0nHs/ShQhux2JiVn8NL675AxjpLRpGXyiyzuL5ZxO6NpbMIbFuIvk9v M9PVHU00vv4F+gfd5DZCV/ydSYUpiHisip5ZSMaEwfOMiLCkhKfrsrG16a4Xd/KA /ljJO+nxvp9/3ldJYmX4dnR9SHEwDSs7mH+U0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=M8TA+FOiFb2/wz eFcFG/DT5nvzc=; b=ADKrIXt6t7aDOB1Fo2pongr2A3mIjJjzJ7Nf3jFt5h7a+X 5jWAR7qmiLapVWf7QrtCeydOOsLqeCE5+BIgHS8i+OajeM8EA+keGJOw3pSat5tU +C4uvPqJ4Aar/FQTqg8+VWky21hTIMmivblxRGLlIwKDldp42LvtZ0Vpfrvmc= X-ME-Sender: X-Sasl-enc: XW1PvK4NumUaJfjuBfrZK7EM4tKP7u0oK/ilQXjEvgTQ 1483665648 Original-Received: from shorty.local (unknown [128.149.110.210]) by mail.messagingengine.com (Postfix) with ESMTPA id E576F24789; Thu, 5 Jan 2017 20:20:48 -0500 (EST) Original-Received: from dima by shorty.local with local (Exim 4.88) (envelope-from ) id 1cPJD5-0001y8-QN; Thu, 05 Jan 2017 17:20:47 -0800 In-reply-to: <87inpt6lce.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127801 Archived-At: Tino Calancha writes: > Mark Oteiza writes: > >> I am guessing this is a consequence of bug#17544. From -Q: >> >> 1. Do C-x v d RET = in a repository with a bunch of worktree changes >> 2. Hit n. Point is now at the top of the SECOND hunk >> 3. Go to end of buffer. >> 4. Hit p. Point is now at the top of the PENULTIMATE hunk > FWIW, to me this behaviour is very annoying and it has being > around already a while without a fix (4 months). > I would propose to revert the commit causing this misbehaviour. > Then, once the patch is mature enough, it can be pushed again without > affecting users. Hi. This isn't a misbehavior, it's the whole point of the patch. We can argue about whether it's an improvement or not, but if this is a "bug", then the solution is a full revert. The behavior I want is to always have a consistent idea of which hunk we are currently on. In the recipe above, between steps 1 and 2 the point is at bob. Both before and after the patch, the codes agree that we are on the hunk 1. When you press 'n', I thus argue you should end up at hunk 2. Similary, when you press C-c C-a; it should apply the first hunk, and move to the second. And so on. What would you like?