From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Prevent ERC from sending spurious PART messages Date: Fri, 31 Mar 2017 00:02:53 +0200 Message-ID: <87tw6axw1e.fsf@linux-m68k.org> References: <6E627702-A0E8-47A6-8794-D90050E2CC13.notmuch@alumni.duke.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1490911389 6287 195.159.176.226 (30 Mar 2017 22:03:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 30 Mar 2017 22:03:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: emacs-devel@gnu.org To: "Victor J. Orlikowski" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 31 00:03:05 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cti9m-0000zp-S8 for ged-emacs-devel@m.gmane.org; Fri, 31 Mar 2017 00:03:02 +0200 Original-Received: from localhost ([::1]:37870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cti9s-0008Mk-P7 for ged-emacs-devel@m.gmane.org; Thu, 30 Mar 2017 18:03:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cti9m-0008MV-At for emacs-devel@gnu.org; Thu, 30 Mar 2017 18:03:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cti9j-0005fY-7j for emacs-devel@gnu.org; Thu, 30 Mar 2017 18:03:02 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:34668) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cti9j-0005ek-1g for emacs-devel@gnu.org; Thu, 30 Mar 2017 18:02:59 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3vvJXb2DNHz1qqkg; Fri, 31 Mar 2017 00:02:54 +0200 (CEST) Original-Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3vvJXZ5N7Kz3jR9r; Fri, 31 Mar 2017 00:02:54 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id N2t0FR_95KMx; Fri, 31 Mar 2017 00:02:54 +0200 (CEST) X-Auth-Info: q1cXculmJohDaNJSlUg5VHHmVMIXHJc2RUF0h1o1AoZFed0z71jmiZ4XKGNyTy+y Original-Received: from igel.home (ppp-88-217-0-63.dynamic.mnet-online.de [88.217.0.63]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 31 Mar 2017 00:02:53 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 641FA2C4182; Fri, 31 Mar 2017 00:02:53 +0200 (CEST) X-Yow: I'm not available for comment.. In-Reply-To: <6E627702-A0E8-47A6-8794-D90050E2CC13.notmuch@alumni.duke.edu> (Victor J. Orlikowski's message of "Thu, 30 Mar 2017 15:41:32 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.18.0.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213538 Archived-At: On M=C3=A4r 30 2017, "Victor J. Orlikowski" wrote: > diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el > index 488404d..357d03c 100644 > --- a/lisp/erc/erc.el > +++ b/lisp/erc/erc.el > @@ -6735,9 +6735,10 @@ This function should be on `erc-kill-server-hook= '." > This function should be on `erc-kill-channel-hook'." > (when (erc-server-process-alive) > (let ((tgt (erc-default-target))) > - (erc-server-send (format "PART %s :%s" tgt > - (funcall erc-part-reason nil)) > - nil tgt)))) > + (unless (not tgt) (unless (not)) =3D=3D (when) Andreas. --=20 Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."