From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Zhitao Gong <zhitaao.gong@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-sort: Read compare-func in interactive calls
Date: Thu, 11 May 2017 23:47:43 +0200 [thread overview]
Message-ID: <87tw4r12ww.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20170509194750.8974-1-kyle@kyleam.com> (Kyle Meyer's message of "Tue, 9 May 2017 15:47:50 -0400")
Hello,
Kyle Meyer <kyle@kyleam.com> writes:
> * lisp/org-macs.el (org-read-function): New function.
> * lisp/org.el (org-sort-entries):
> * lisp/org-table.el (org-table-sort-lines):
> * lisp/org-list.el (org-sort-list): Read COMPARE-FUNC when called
> interactively rather than being restricted to the default behavior of
> sort-subr's PREDICATE parameter. Guard prompts for GETKEY-FUNC and
> COMPARE-FUNCTION with called-interactively-p, like
> org-table-sort-lines already did for GETKEY-FUNC.
Thank you. I have but one comment.
> + (sort-func
> + (cond
> + ((= dcst ?a) #'string<)
> + ((= dcst ?f)
> + (or compare-func
> + (and (called-interactively-p 'any)
The above should be avoided. See `called-interactively-p' docstring. The
same applies in other places.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-05-11 21:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 19:36 About org-sort -> org-sort-list with custom sort function Zhitao Gong
2017-05-07 2:55 ` Kyle Meyer
2017-05-07 10:00 ` Nicolas Goaziou
2017-05-07 14:20 ` Kyle Meyer
2017-05-07 15:37 ` Kyle Meyer
2017-05-08 9:48 ` Nicolas Goaziou
2017-05-08 15:24 ` Kyle Meyer
2017-05-08 16:23 ` Nicolas Goaziou
2017-05-08 16:45 ` Kyle Meyer
2017-05-08 16:48 ` Nicolas Goaziou
2017-05-09 19:47 ` [PATCH] org-sort: Read compare-func in interactive calls Kyle Meyer
2017-05-11 21:47 ` Nicolas Goaziou [this message]
2017-05-12 1:48 ` Kyle Meyer
2017-05-12 7:10 ` Nicolas Goaziou
2017-05-13 14:50 ` [PATCH v2] " Kyle Meyer
2017-05-14 8:24 ` Nicolas Goaziou
2017-05-14 13:45 ` Kyle Meyer
2017-05-14 16:51 ` Nicolas Goaziou
2017-05-14 20:54 ` Kyle Meyer
2017-05-17 12:32 ` Nicolas Goaziou
2017-05-09 4:10 ` About org-sort -> org-sort-list with custom sort function Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw4r12ww.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
--cc=zhitaao.gong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.