From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Re: master 69fb12a: (loadhist-unload-element): Move ERT and cl-generic methods Date: Tue, 25 Jul 2017 00:46:56 -0600 Message-ID: <87tw21ggin.fsf@lylat> References: <20170724195836.5168.34164@vcs0.savannah.gnu.org> <20170724195837.544B924C49@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500965430 30529 195.159.176.226 (25 Jul 2017 06:50:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Jul 2017 06:50:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 25 08:50:20 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZtfe-0007KS-G8 for ged-emacs-devel@m.gmane.org; Tue, 25 Jul 2017 08:50:18 +0200 Original-Received: from localhost ([::1]:58786 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZtfk-0004xk-4r for ged-emacs-devel@m.gmane.org; Tue, 25 Jul 2017 02:50:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZtdi-00040d-6f for emacs-devel@gnu.org; Tue, 25 Jul 2017 02:48:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZtdb-0003Ky-7Y for emacs-devel@gnu.org; Tue, 25 Jul 2017 02:48:15 -0400 Original-Received: from mail-io0-x241.google.com ([2607:f8b0:4001:c06::241]:33232) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZtdb-0003KY-2W for emacs-devel@gnu.org; Tue, 25 Jul 2017 02:48:11 -0400 Original-Received: by mail-io0-x241.google.com with SMTP id q64so3262149ioi.0 for ; Mon, 24 Jul 2017 23:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qbVauSXIRku5EodO2s6MqAzudHgje3RiGoHgRwW0qcY=; b=PvM7rMRK7t4aItXQf9MmuDq3PmCki/g7xIYlFOivzCH3tU8WxqEdwX38rA/KQmIdzz DvDqX5Z/TUmOkdonGaZWuupCVOR01XBmRZDnoYRC/A/zeKdKEbyqncLzReUOHQXrOS50 szdWe33fgGRXr3I9lwxwIyMDJq6FQe+7v6hnS3Nqk0S1AhjblS4436tBRCH76JlEDtOF finFd0ZLeVv7QYFSHoFiTOc9xoW0+cueXDU0RGQcBxa5q9yKlV0X3vpEh+QawqJGMQBc TrSJMJUzEof44Cqi8r+K1+U2oGmCJae06Jl79sPJMGqOS8pk6vzrO+Dg01HbxPEdRL3t X7+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qbVauSXIRku5EodO2s6MqAzudHgje3RiGoHgRwW0qcY=; b=JlT6QSCDvtqCLdgW8xKP4pmXz5rOGckwq+376TwQAkLguXW3tHEaiIbf/cKZ2GJaLm WWdAKemkgHz9qBbIvGD8jsXGuCh0YxG3QqSv3d2QUR9ENmKmG6c8CDv37InALhDaw+eG EeCQH7RjwZmAD0NJwSZNPZMjKtrSfy4JtP00rDcCQzMRv100uYHjdrieeJFVh3UrFu+v dPdw3qsVAan/Z7Ty32YzTcekGpRb+jql1Vp9bLtbhlPvrs+MttwYIPEZ7e7kACcZzynE 46QbTpAW/TBv80uIkJtAQq8J2eq5qv0Ne9PEHNrymEkqurtEEfO9c89heAx4dPLhG9HB nDdw== X-Gm-Message-State: AIVw1129CyvICVJ6+sQxwTtiUvTdakWxzu+WrEhSNucUNwp9v2QVR3La 0hPlA/Yc2hSKEQOd X-Received: by 10.107.3.67 with SMTP id 64mr17622708iod.307.1500965288554; Mon, 24 Jul 2017 23:48:08 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id a197sm4686898itc.5.2017.07.24.23.48.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jul 2017 23:48:07 -0700 (PDT) In-Reply-To: <20170724195837.544B924C49@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 24 Jul 2017 15:58:36 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217011 Archived-At: monnier@iro.umontreal.ca (Stefan Monnier) writes: > branch: master > commit 69fb12a66b3d6b9bfb55d8bcd58bec2a8e7ca55b > Author: Stefan Monnier > Commit: Stefan Monnier > > (loadhist-unload-element): Move ERT and cl-generic methods > > * lisp/loadhist.el (loadhist-unload-element): Don't define cl-generic > and ert methods here. > (loadhist-unload-element) <(head define-type)>: Remove unused var `slots'. > > * lisp/emacs-lisp/cl-generic.el (loadhist-unload-element): Define > unload method for cl-defmethod. > (cl-generic-ensure-function): Remove redundant `defalias'. > > * lisp/emacs-lisp/ert.el (ert-set-test): Move the current-load-list > setting here... > (ert-deftest): ...from here. > (loadhist-unload-element): Define unload method for ert-deftest. This commit breaks defgeneric for me. Specifically, this: (eieio--defgeneric-init-form 'test "Hello") returns nil after this commit, leading to an assertion error in eieio--defalias. I found this out because I couldn't load Helm (the problem file is helm-source.el).