From: Alex <agrambot@gmail.com>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master 69fb12a: (loadhist-unload-element): Move ERT and cl-generic methods
Date: Tue, 25 Jul 2017 00:46:56 -0600 [thread overview]
Message-ID: <87tw21ggin.fsf@lylat> (raw)
In-Reply-To: <20170724195837.544B924C49@vcs0.savannah.gnu.org> (Stefan Monnier's message of "Mon, 24 Jul 2017 15:58:36 -0400 (EDT)")
monnier@iro.umontreal.ca (Stefan Monnier) writes:
> branch: master
> commit 69fb12a66b3d6b9bfb55d8bcd58bec2a8e7ca55b
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> (loadhist-unload-element): Move ERT and cl-generic methods
>
> * lisp/loadhist.el (loadhist-unload-element): Don't define cl-generic
> and ert methods here.
> (loadhist-unload-element) <(head define-type)>: Remove unused var `slots'.
>
> * lisp/emacs-lisp/cl-generic.el (loadhist-unload-element): Define
> unload method for cl-defmethod.
> (cl-generic-ensure-function): Remove redundant `defalias'.
>
> * lisp/emacs-lisp/ert.el (ert-set-test): Move the current-load-list
> setting here...
> (ert-deftest): ...from here.
> (loadhist-unload-element): Define unload method for ert-deftest.
This commit breaks defgeneric for me. Specifically, this:
(eieio--defgeneric-init-form 'test "Hello")
returns nil after this commit, leading to an assertion error in
eieio--defalias.
I found this out because I couldn't load Helm (the problem file is
helm-source.el).
next parent reply other threads:[~2017-07-25 6:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170724195836.5168.34164@vcs0.savannah.gnu.org>
[not found] ` <20170724195837.544B924C49@vcs0.savannah.gnu.org>
2017-07-25 6:46 ` Alex [this message]
2017-07-25 14:13 ` master 69fb12a: (loadhist-unload-element): Move ERT and cl-generic methods Stefan Monnier
2017-07-26 16:43 ` Glenn Morris
2017-07-26 18:06 ` Hanging Tramp tests (was: master 69fb12a: (loadhist-unload-element): Move ERT and cl-generic methods) Michael Albinus
2017-07-26 18:28 ` Noam Postavsky
2017-07-27 10:53 ` Hanging Tramp tests Michael Albinus
2017-07-27 21:47 ` master 69fb12a: (loadhist-unload-element): Move ERT and cl-generic methods Dmitry Gutov
2017-07-28 2:04 ` Stefan Monnier
2017-07-28 18:36 ` Rob Browning
2017-07-29 7:54 ` Hanging Tramp tests (was: master 69fb12a: (loadhist-unload-element): Move ERT and cl-generic methods) Michael Albinus
2017-07-29 18:03 ` Rob Browning
2017-07-30 16:12 ` Hanging Tramp tests Michael Albinus
2017-07-30 16:22 ` Rob Browning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw21ggin.fsf@lylat \
--to=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.