From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#27940: Recursively delete dir34? (yes, no, all, quit) Date: Mon, 16 Oct 2017 06:36:13 -0400 Message-ID: <87tvyzgz1e.fsf@users.sourceforge.net> References: <87o9rwxmfz.fsf@jidanni.org> <87r2wrkacy.fsf@calancha-pc> <83a83fybrc.fsf@gnu.org> <87vam365q2.fsf@calancha-pc> <834ltnxzyz.fsf@gnu.org> <871sorz9kg.fsf@calancha-pc> <83tw1nwfhp.fsf@gnu.org> <87r2wppabm.fsf@calancha-pc> <87k22e9obk.fsf@ctlt579.codethink.co.uk> <87shek8pi4.fsf@users.sourceforge.net> <87k1zv3bzw.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508150228 6634 195.159.176.226 (16 Oct 2017 10:37:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 10:37:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 27940@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 16 12:37:04 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e42lb-0001CB-TG for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 12:37:04 +0200 Original-Received: from localhost ([::1]:60361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e42lj-0000BT-1F for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 06:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e42ld-0000BO-95 for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 06:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e42la-0002hx-6H for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 06:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33858) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e42la-0002hr-1l for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 06:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e42lZ-0003qO-JN for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 06:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2017 10:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27940-submit@debbugs.gnu.org id=B27940.150815018414723 (code B ref 27940); Mon, 16 Oct 2017 10:37:01 +0000 Original-Received: (at 27940) by debbugs.gnu.org; 16 Oct 2017 10:36:24 +0000 Original-Received: from localhost ([127.0.0.1]:42539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e42kx-0003pP-KY for submit@debbugs.gnu.org; Mon, 16 Oct 2017 06:36:23 -0400 Original-Received: from mail-it0-f47.google.com ([209.85.214.47]:50403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e42kw-0003pA-3g for 27940@debbugs.gnu.org; Mon, 16 Oct 2017 06:36:22 -0400 Original-Received: by mail-it0-f47.google.com with SMTP id 72so622514itl.5 for <27940@debbugs.gnu.org>; Mon, 16 Oct 2017 03:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hzzFDLRf4zr1ADItISy8RJaxqSlWfSTMe7LbnELxQ0A=; b=WVe+tYQqMsFfNcy6mLnUJQwLLkv+GKa+RG+N32Fa6Aq4bD2GJ0mvo+7AkomoO1WxMV gh+8/58JT2/gsaHbQENTFn4XW2YK7poAB/abVgjxhc1hVQr55oIzeuYTLib+FInA2px9 4b9mgopG7L8BlZTZZ8R9szvjdMGpUD76GeyG+/RN/074z+EYuXNsuy+ardWpabbw88Ao g8bKY90GHQzheWmuCYAQD7u4xh9BTW6WlekvCtKHK21rNx9CbJqZaeHVR2bm7t/MQJmG EY/0AwHZAfGpfz7dB5VnsJD7ymkelYKX1UnDBicBxLmxldFWf74acdrZ7EhixFuCDw8A 4FCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=hzzFDLRf4zr1ADItISy8RJaxqSlWfSTMe7LbnELxQ0A=; b=qIk7bY0NBwC5yqO+IbaoLQvIFWIOYi9zbjXDIm2k8ohi4YTdXCyszpTkOP3r/CISdC 6F15Uf37mOsafKK+DFFxCbID8/A3RZNFd7H6DdlgigSevTDj8DxemmnmJKFqvFvCh6o5 FGhGOVJnKcJZujklFU33YfLu5xQKucbmbGM3QGm67N4Zj1HufSSCkq2qd+K3pbx2JMOD ded3MSt/pqzAbicu+Cmv3+A3LaFo6EHGq446JoxBXRPTrPsCojOQH/B8GnN5HBYoyaU0 WMR6SxArW42PtSe3nkOegHRap3bf32UdFF4sEnSU+5zKfdzGJC1RVMl4iEuX6um5hIdq RQ+A== X-Gm-Message-State: AMCzsaWEe7EwA9Vr5QlWZ910ZFBb2ehc/06IEm/rJpncenBdmPfU2IyB dmVEB+MYQ9f7JHcRFul6wSrFkg== X-Google-Smtp-Source: ABhQp+QBQkhr1INLJ7WxmnQejytM4j+8YW4nzvCutRuCYDw5xgyCHGdFLu7BauCijZmiD2dkqcLFSQ== X-Received: by 10.36.246.74 with SMTP id u71mr528404ith.104.1508150176124; Mon, 16 Oct 2017 03:36:16 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id f12sm1505403itc.1.2017.10.16.03.36.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Oct 2017 03:36:14 -0700 (PDT) In-Reply-To: <87k1zv3bzw.fsf@gmail.com> (Tino Calancha's message of "Mon, 16 Oct 2017 14:20:03 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138510 Archived-At: Tino Calancha writes: > Those tests implicitely assume you keep the > 'dired-recursive-deletes' default, i.e. 'top; IMO it's not > sorprising that they fail if you run them interactively > with other 'dired-recursive-deletes' value. It is failing for me when I run non-interactively: make -C test dired-tests Does it not fail for you? > We could explicitely set 'dired-recursive-deletes' 'top if you > prefer that. I tried also binding it during the test, but it still failed: modified test/lisp/dired-tests.el @@ -364,7 +364,8 @@ dired-test-with-temp-dirs (declare (indent 1) (debug body)) (let ((dir (make-symbol "dir")) (ignore-funcs (make-symbol "ignore-funcs"))) - `(let* ((,dir (make-temp-file "bug27940" t)) + `(let* ((dired-recursive-deletes 'top) + (,dir (make-temp-file "bug27940" t)) (dired-deletion-confirmer (lambda (_) "yes")) ; Suppress prompts. (inhibit-message t) (default-directory ,dir))