all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex <agrambot@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 28855@debbugs.gnu.org, monnier@iro.umontreal.ca, johnw@gnu.org,
	dgutov@yandex.ru
Subject: bug#28855: 26.0.90; display-line-numbers-mode does not respect (line|wrap)-prefix '(space :align-to N) text property
Date: Wed, 18 Oct 2017 23:54:54 -0600	[thread overview]
Message-ID: <87tvyvk7gx.fsf@gmail.com> (raw)
In-Reply-To: <838tg7es1q.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Oct 2017 06:26:57 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> Yes (although it turned out during a previous discussion that "text
> area" is not understood the same by all the parties ;-)

Yeah, my bad (though now I'm using the definition from (elisp) Window
Sizes :-).

>> What about starting the measurement from after the line-prefix attribute
>> as well?
>
> I don't plan doing that, certainly not for Emacs 26.  The line-prefix
> and wrap-prefix are very old features, and no one asked for :align-to
> to know about them till now, so presumably it isn't very important.
> (It also sounds like :align-to itself is rarely used and sometimes is
> entirely unfamiliar-with.  I certainly don't see some of its features
> used in Emacs at all, which makes me wonder why did we implement them
> in Emacs 21.)

It doesn't seem that line/wrap-prefix are very commonly used (though
perhaps I'm just not using the relevant packages), so coupled with
:align-to's rarity it doesn't seem surprising that no one has asked for
it until now.

Anyway, my argument is still that I believe a default starting point
past the *-prefix area is more intuitive than before it. I figured that
since you brought up changing the default starting point, that I might
as well run it by you again.

Just accounting for line-numbers is better than the current behaviour,
but if you do decide to do that, then it would be nice to have something
along the lines of:

  :align-to (+ prefix prefix N)

That would mean "offset from the *-prefix area", which would let you
align to non-prefix text in the buffer.

>> If there's a distinct element for line-numbers, then you don't have to
>> worry about what elements are on the left, or what order they're in.
>
> My assumption is that no one will need to worry about that because
> everybody will want the automatic accounting for the line numbers I'm
> about to implement.  The above is just a fire escape I don't envision
> to be needed, certainly not frequently.

I think it's unlikely that one would want to account for line-numbers
and not line/wrap-prefix, but I figure that it would be nice to provide
a flexible fire escape.

Still, if alignment treats line-numbers specially, then I think it makes
sense to provide it as a full-fledged element for pixel specifications.





  reply	other threads:[~2017-10-19  5:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16  3:38 bug#28855: 26.0.90; display-line-numbers-mode does not respect (line|wrap)-prefix '(space :align-to N) text property Paul Rankin
2017-10-16 16:05 ` Eli Zaretskii
2017-10-17  0:47   ` Paul Rankin
2017-10-17  2:44     ` Eli Zaretskii
2017-10-17  4:04       ` Eli Zaretskii
2017-10-17  4:32         ` Paul Rankin
2017-10-17  5:49           ` Eli Zaretskii
2017-10-17  7:17             ` Paul Rankin
2017-10-18  9:29   ` Dmitry Gutov
2017-10-18 16:47     ` Eli Zaretskii
2017-10-18 17:44       ` martin rudalics
2017-10-18 17:55         ` Eli Zaretskii
2017-10-20  9:40           ` Eli Zaretskii
2017-10-18 18:05         ` Eli Zaretskii
2017-10-18 18:34           ` martin rudalics
2017-10-18 18:44             ` Eli Zaretskii
2017-10-18 23:58           ` Alex
2017-10-19  3:26             ` Eli Zaretskii
2017-10-19  5:54               ` Alex [this message]
2017-10-20  7:03                 ` Eli Zaretskii
2017-10-18 22:52       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvyvk7gx.fsf@gmail.com \
    --to=agrambot@gmail.com \
    --cc=28855@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=johnw@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.