From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29821: Ensure quick substitution only occurs at start of line Date: Mon, 01 Jan 2018 22:58:06 -0500 Message-ID: <87tvw4syi9.fsf@users.sourceforge.net> References: <87fu8272h6.fsf@gmail.com> <87shbqto33.fsf@users.sourceforge.net> <87wp11rqtr.fsf@users.sourceforge.net> <871sj96lgu.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1514865445 14179 195.159.176.226 (2 Jan 2018 03:57:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Jan 2018 03:57:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29821@debbugs.gnu.org, Andreas Schwab To: Jay Kamat Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 02 04:57:21 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWDhQ-0002hI-Kf for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 04:57:12 +0100 Original-Received: from localhost ([::1]:55345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWDjO-0008Af-1H for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Jan 2018 22:59:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWDjH-0008AI-Cr for bug-gnu-emacs@gnu.org; Mon, 01 Jan 2018 22:59:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWDjC-0004vp-Hz for bug-gnu-emacs@gnu.org; Mon, 01 Jan 2018 22:59:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51686) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWDjC-0004vj-EU for bug-gnu-emacs@gnu.org; Mon, 01 Jan 2018 22:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWDjC-00071f-65 for bug-gnu-emacs@gnu.org; Mon, 01 Jan 2018 22:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jan 2018 03:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29821 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29821-submit@debbugs.gnu.org id=B29821.151486549726957 (code B ref 29821); Tue, 02 Jan 2018 03:59:02 +0000 Original-Received: (at 29821) by debbugs.gnu.org; 2 Jan 2018 03:58:17 +0000 Original-Received: from localhost ([127.0.0.1]:60367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWDiS-00070j-PW for submit@debbugs.gnu.org; Mon, 01 Jan 2018 22:58:16 -0500 Original-Received: from mail-io0-f171.google.com ([209.85.223.171]:42639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWDiR-00070U-0W for 29821@debbugs.gnu.org; Mon, 01 Jan 2018 22:58:15 -0500 Original-Received: by mail-io0-f171.google.com with SMTP id x67so41623200ioi.9 for <29821@debbugs.gnu.org>; Mon, 01 Jan 2018 19:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZYFoTDEQPEZuAKJl6XLi0+onjceKI/xh31ZylYv15PE=; b=owXa8CJLqRktYAMbsdwaLpqlxRjh1gnfnDKF/AQeUSILYMmIAzUWH4OVLQhykXnk6w bOQ92NuTJPvXqmJRgfPnrN7acPiV+dMPKi0u+5UHDTTQ2FEWyvijUqg3wad5kFf4jDdO K+QYFyAAjul1rWF6NCQbnPSIYYuR/Xu/2tkA5EIoSzpPowqcr+qZMARiotwnuoIEpQjn i4MSTtk2qO1BlPXPEMehhP00NsM/NALBeNPOKZX380jWGqGKG6fmR9d9i8T1Fr+YDdQZ p8XJa8y4wDmt5mqRvwRlkRq6FDtB5qoTEv5Lp9NCE5NeGei2K6Y+TOq5nBuwVw2nLcKC KKvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ZYFoTDEQPEZuAKJl6XLi0+onjceKI/xh31ZylYv15PE=; b=cIIhRKiwh4XbcXFu/j1DXIyIHVH/a8l24l/jgCNDOSdXH1iWrgg0czjv/d9UJgp0L5 jQkVQVg9uE458IFncXJXTKohZGoRJDzDW61F+mH1C/sZWpQO4SGDVPs2db/r012USDc6 6+FblY/HdZ6Wy68FrDUdrquDM9MC12032dYTdrKuWm4MMcKslu4lIe411N2zc+u/yqTb A32meJL9g+VLDNqq8YawznuevQV3fewjVD436csWlP1Or/i9y3356hBF1fimHv0fFnsw jU3wmuEleuhs/nJgnWicssP4nV73R++8RPC+rMSuo3oMgaqHHYNq7S7GMBfz8x1/y241 jzYw== X-Gm-Message-State: AKGB3mLTtVG2R8akBCAO2A6cXtPm5p4AszNRvbQxgcl3cyS/ZD8pyD0r +Z+LiGzgoiFyYP/Snqkz1PU= X-Google-Smtp-Source: ACJfBosXzfwm0KiKpy3L4Ogif6YbEcQqOQjMwgZS3A3nCm9kW2khfZTrr9IsBoOV3ftRM7g3wLF9Bw== X-Received: by 10.107.51.212 with SMTP id z203mr57974348ioz.126.1514865489054; Mon, 01 Jan 2018 19:58:09 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 86sm18155615iom.31.2018.01.01.19.58.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Jan 2018 19:58:07 -0800 (PST) In-Reply-To: <871sj96lgu.fsf@gmail.com> (Jay Kamat's message of "Mon, 01 Jan 2018 18:30:41 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141707 Archived-At: Jay Kamat writes: > Ah, I did notice that, but I was not sure whether it was a bug or > desired behavior (as it seemed to occur for me even before this > patch). Oh right, I didn't notice because I tested with spaces. Still, I think since we're trying to make this behave like bash, we should try to get as close as possible. > I've added a tiny change to the patch to fix that, but it has the side > effect of doing: > >> *[j@laythe emacs-bisect]$ echo "foo"(:s/bar/baz/) >> foo: substitution failed > > But I think that's an OK change, especially if we want to error out on > ^bar^baz when no search is found. > I also discovered another issue (which existed before as well): > >> *[j@laythe emacs-bisect]$ echo one one one >> ("one" "one" "one") >> *[j@laythe emacs-bisect]$ !!:sg/one/two >> :sg/one/two >> Wrong type argument: integer-or-marker-p, nil > > but I'd rather take a look at that later on to avoid cluttering this > changeset. (and I'm not sure if I'm just using the feature incorrectly). !!:gs/one/two/ seems to work. The error message could be improved though (but yes, we should do that separately). > +(defun eshell-history-substitution (line) > + "Expand whole-line history substitutions by converting them to > +!!:s/a/b/ syntax. > +Returns nil if no match found." Couldn't you error here (if the line matches ^...^...^) instead of returning nil, and then avoid affecting the other substitution? (although I agree signaling an error in the other place is probably acceptable)