From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Jay Kamat <jaygkamat@gmail.com>
Cc: 29821@debbugs.gnu.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: bug#29821: Ensure quick substitution only occurs at start of line
Date: Mon, 01 Jan 2018 22:58:06 -0500 [thread overview]
Message-ID: <87tvw4syi9.fsf@users.sourceforge.net> (raw)
In-Reply-To: <871sj96lgu.fsf@gmail.com> (Jay Kamat's message of "Mon, 01 Jan 2018 18:30:41 -0800")
Jay Kamat <jaygkamat@gmail.com> writes:
> Ah, I did notice that, but I was not sure whether it was a bug or
> desired behavior (as it seemed to occur for me even before this
> patch).
Oh right, I didn't notice because I tested with spaces. Still, I think
since we're trying to make this behave like bash, we should try to get
as close as possible.
> I've added a tiny change to the patch to fix that, but it has the side
> effect of doing:
>
>> *[j@laythe emacs-bisect]$ echo "foo"(:s/bar/baz/)
>> foo: substitution failed
>
> But I think that's an OK change, especially if we want to error out on
> ^bar^baz when no search is found.
> I also discovered another issue (which existed before as well):
>
>> *[j@laythe emacs-bisect]$ echo one one one
>> ("one" "one" "one")
>> *[j@laythe emacs-bisect]$ !!:sg/one/two
>> :sg/one/two
>> Wrong type argument: integer-or-marker-p, nil
>
> but I'd rather take a look at that later on to avoid cluttering this
> changeset. (and I'm not sure if I'm just using the feature incorrectly).
!!:gs/one/two/ seems to work. The error message could be improved
though (but yes, we should do that separately).
> +(defun eshell-history-substitution (line)
> + "Expand whole-line history substitutions by converting them to
> +!!:s/a/b/ syntax.
> +Returns nil if no match found."
Couldn't you error here (if the line matches ^...^...^) instead of
returning nil, and then avoid affecting the other substitution?
(although I agree signaling an error in the other place is probably
acceptable)
next prev parent reply other threads:[~2018-01-02 3:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 23:57 bug#29821: Ensure quick substitution only occurs at start of line Jay Kamat
2018-01-01 0:33 ` Noam Postavsky
2018-01-01 9:56 ` Andreas Schwab
2018-01-02 1:29 ` Noam Postavsky
2018-01-02 2:30 ` Jay Kamat
2018-01-02 3:58 ` Noam Postavsky [this message]
2018-01-02 17:48 ` Jay Kamat
2018-01-03 1:51 ` Noam Postavsky
2018-01-04 1:17 ` Jay Kamat
2018-01-04 3:10 ` Noam Postavsky
2018-01-04 20:26 ` Jay Kamat
2018-01-05 1:04 ` Noam Postavsky
2018-01-05 1:53 ` Jay Kamat
2018-01-05 14:31 ` Noam Postavsky
2018-01-01 23:44 ` Jay Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvw4syi9.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=29821@debbugs.gnu.org \
--cc=jaygkamat@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.