From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Juri Linkov <juri@linkov.net>, 30280@debbugs.gnu.org, rrt@sc3d.org
Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore
Date: Sat, 03 Feb 2018 14:13:15 +0000 [thread overview]
Message-ID: <87tvuyqhz8.fsf@tcd.ie> (raw)
In-Reply-To: <83lggbd661.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 2 Feb 2018 12:42:14 +0200")
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-lisp-simple.el-async-shell-command-shell-command-Fix.patch --]
[-- Type: text/x-diff, Size: 1916 bytes --]
From b5167407b464a13968af600ac3d09f13d52e6d26 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Sat, 3 Feb 2018 13:52:03 +0000
Subject: * lisp/simple.el (async-shell-command, shell-command): Fix grammar
---
lisp/simple.el | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lisp/simple.el b/lisp/simple.el
index e2deceb4c2..b7ad6ebd79 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3351,15 +3351,15 @@ async-shell-command
The output appears in the buffer `*Async Shell Command*'.
That buffer is in shell mode.
-You can configure `async-shell-command-buffer' to specify what to do in
-case when `*Async Shell Command*' buffer is already taken by another
+You can configure `async-shell-command-buffer' to specify what to do
+when the `*Async Shell Command*' buffer is already taken by another
running shell command. To run COMMAND without displaying the output
in a window you can configure `display-buffer-alist' to use the action
`display-buffer-no-window' for the buffer `*Async Shell Command*'.
In Elisp, you will often be better served by calling `start-process'
-directly, since it offers more control and does not impose the use of a
-shell (with its need to quote arguments)."
+directly, since it offers more control and does not impose the use of
+a shell (with its need to quote arguments)."
(interactive
(list
(read-shell-command "Async shell command: " nil nil
@@ -3428,8 +3428,8 @@ shell-command
specifies the value of ERROR-BUFFER.
In Elisp, you will often be better served by calling `call-process' or
-`start-process' directly, since it offers more control and does not impose
-the use of a shell (with its need to quote arguments)."
+`start-process' directly, since they offer more control and do not
+impose the use of a shell (with its need to quote arguments)."
(interactive
(list
--
2.15.1
[-- Attachment #2: Type: text/plain, Size: 263 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> Thanks, I confirm this is the right thing to do and your patch fixes
>> the reported issue.
>
> Then please push them to the emacs-26 branch, and thanks.
Perhaps I can sneak in the attached doc fixes as well.
--
Basil
next prev parent reply other threads:[~2018-02-03 14:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 22:20 bug#30280: async-shell-command-display-buffer doesn't work anymore Juri Linkov
2018-01-29 17:24 ` Eli Zaretskii
2018-01-29 21:40 ` Juri Linkov
2018-01-30 3:24 ` Eli Zaretskii
2018-01-30 18:53 ` Basil L. Contovounesios
2018-01-30 19:06 ` Reuben Thomas
2018-01-31 21:44 ` Juri Linkov
2018-02-02 10:42 ` Eli Zaretskii
2018-02-03 14:13 ` Basil L. Contovounesios [this message]
2018-02-03 21:27 ` Juri Linkov
2018-05-06 16:18 ` Basil L. Contovounesios
2018-05-07 7:35 ` Tino Calancha
2018-05-09 11:54 ` Basil L. Contovounesios
2018-05-09 13:57 ` Tino Calancha
2018-05-09 14:10 ` Noam Postavsky
2018-05-09 14:24 ` Tino Calancha
2018-05-09 18:29 ` Basil L. Contovounesios
2018-05-10 2:13 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvuyqhz8.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=30280@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.