From: Juri Linkov <juri@linkov.net>
To: Leo Liu <sdl.web@gmail.com>
Cc: 30187@debbugs.gnu.org
Subject: bug#30187: master a710f8a: * lisp/comint.el (comint-history-isearch-setup): Check if process is live.
Date: Wed, 07 Feb 2018 23:20:02 +0200 [thread overview]
Message-ID: <87tvush4zh.fsf@mail.linkov.net> (raw)
In-Reply-To: <m1372dzjeb.fsf@gmail.com> (Leo Liu's message of "Wed, 07 Feb 2018 09:19:08 +0800")
> Changing comint-history-isearch-setup this way seems too pervasive. I
> have a use case where (get-buffer-process (current-buffer)) is always
> nil. Is there another way to work around the issue in *Async Shell
> Command*? Thanks.
Before this fix the search was broken in *Async Shell Command*
and in inactive shells.
For example, try to set comint-history-isearch to ‘dwim’
and type ‘C-r’ in a *Async Shell Command* buffer. It fails with
Lisp error: (wrong-type-argument processp nil)
process-mark(nil)
comint-after-pmark-p()
comint-history-isearch-setup()
...
Or even when comint-history-isearch is nil by default, run shell ‘M-x shell’,
then exit it, and after “Process shell finished” type ‘M-r’ and any letter
to search for it:
Lisp error: (wrong-type-argument processp nil)
process-mark(nil)
comint-delete-input()
comint-goto-input(nil)
comint-history-isearch-pop-state
...
In these cases the history can't be searched because there is no active shell.
I wonder what use case do you need in inactive shells without a prompt,
so it's impossible to search in the history. How you used to search
through the shell history without failing in ‘comint-goto-input’ like
in the backtrace above?
next prev parent reply other threads:[~2018-02-07 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180206213907.23079.76097@vcs0.savannah.gnu.org>
[not found] ` <20180206213908.03CCC208E4@vcs0.savannah.gnu.org>
2018-02-07 1:19 ` master a710f8a: * lisp/comint.el (comint-history-isearch-setup): Check if process is live Leo Liu
2018-02-07 21:20 ` Juri Linkov [this message]
2018-02-08 3:13 ` bug#30187: " Leo Liu
2018-02-08 21:29 ` Juri Linkov
2018-02-09 2:45 ` Leo Liu
2018-02-11 21:44 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvush4zh.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=30187@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.