From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#30745: 26.0.91; ert should macros nest strangely Date: Wed, 07 Mar 2018 22:24:38 +0000 Message-ID: <87tvtr34nt.fsf@russet.org.uk> References: <874llr4lk1.fsf@russet.org.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1520461404 32741 195.159.176.226 (7 Mar 2018 22:23:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Mar 2018 22:23:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) To: 30745@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 07 23:23:20 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ethSo-0006YM-Eb for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Mar 2018 23:23:11 +0100 Original-Received: from localhost ([::1]:35852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ethUr-0007a6-1o for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Mar 2018 17:25:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ethUh-0007YY-E4 for bug-gnu-emacs@gnu.org; Wed, 07 Mar 2018 17:25:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ethUc-0001wy-Gj for bug-gnu-emacs@gnu.org; Wed, 07 Mar 2018 17:25:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ethUc-0001wR-7n for bug-gnu-emacs@gnu.org; Wed, 07 Mar 2018 17:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ethUb-0005Q1-UL for bug-gnu-emacs@gnu.org; Wed, 07 Mar 2018 17:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Mar 2018 22:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30745-submit@debbugs.gnu.org id=B30745.152046148720803 (code B ref 30745); Wed, 07 Mar 2018 22:25:01 +0000 Original-Received: (at 30745) by debbugs.gnu.org; 7 Mar 2018 22:24:47 +0000 Original-Received: from localhost ([127.0.0.1]:49967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ethUN-0005PT-8H for submit@debbugs.gnu.org; Wed, 07 Mar 2018 17:24:47 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:44294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ethUK-0005PF-QI for 30745@debbugs.gnu.org; Wed, 07 Mar 2018 17:24:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=61CzuFpfwNViT8f3Q250cUATkYox/R0F6f/RZkcTRO8=; b=GKEkmdsXdCxwOHUkk4w3jrPVz cG6zzPdTXwPFiL2M3cFEniZOQ745OgsnvTSv9Z3xGvWMbMu38GhKF+GZ1WBmg1x6YRolRgL9qxg55 0hjlYYUs0tSATatk/4uvcZVCbSipQuHGu9D2tHplXf2GU26lNCfqBmZ9xjnRW1Q9NAvUt1OZ2o+6U 6rIOheIZoAYOCJE3KnviTjpmdelHE3OAZcuJWduo2enXMkSpjh/EZtp9mb0RXxqnbE46V/0SFfroN 9umXnwKUeySZk8J7d1NNUfnU/RYnMZb95l/cWt0Ca/3DZI+R8xb+8oEz4ybLDb52agrrQefJrYGp7 B3s/6xPtQ==; Original-Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:53588 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1ethUE-003Kfl-E5 for 30745@debbugs.gnu.org; Wed, 07 Mar 2018 22:24:38 +0000 In-Reply-To: <874llr4lk1.fsf@russet.org.uk> (Phillip Lord's message of "Wed, 07 Mar 2018 21:34:22 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144012 This reproduction with a simpler test shows that the problem is nesting. (require 'ert) (defun simple-test () (ert-test-result-with-condition-condition (ert-run-test (make-ert-test :body (lambda () (should (eq 1 2))))))) (princ (simple-test)) (princ "\nAnd forcibly unnested\n") (princ (let ((res (simple-test))) (should (equal '(ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil)) res)))) (princ "\nAnd nested\n") (princ (should (equal '(ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil)) (simple-test)))) (princ "\n") Emacs-25 (ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil)) And forcibly unnested t And nested t Emacs-26 (ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil)) And forcibly unnested t And nested Test failed: ((should (equal (quote (ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil))) (simple-test))) :form (equal (ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil)) (((should (eq 1 2)) :form (eq 1 2) :value nil))) :value nil :explanation (proper-lists-of-different-length 2 1 (ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil)) (((should (eq 1 2)) :form (eq 1 2) :value nil)) first-mismatch-at 0))