From: John Shahid <jvshahid@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Let's make C-M-w in isearch yank symbol, not delete character
Date: Sat, 10 Mar 2018 13:34:49 -0500 [thread overview]
Message-ID: <87tvtn3hkm.fsf@gmail.com> (raw)
In-Reply-To: <878tb4vowd.fsf@mail.linkov.net>
Does it make sense to set the `isearch-move' property on some common
forward commands, e.g. `forward-char', `forward-symbol' &
`forward-word'. I just compiled and tried the latest master to test this
feature and it wasn't immediately obvious that I had to set the property
for those commands. I was confused because I expected the built-in
functions to work out of the box with this new feature.
cheers,
-js
Juri Linkov <juri@linkov.net> writes:
>>> >> Error in pre-command-hook (isearch-pre-command-hook):
>>> >> (wrong-type-argument characterp right)
>>> >>
>>> >> Error in pre-command-hook (isearch-pre-command-hook):
>>> >> (wrong-type-argument characterp 134217830)
>>> >
>>> > That's a bug that needs to be fixed, I think.
>>>
>>> Unfortunately, I have no idea what characters to append to the
>>> search string in such cases.
>>
>> How about nothing?
>
> This reduces the usefulness of this feature.
> But OK, here is a new option for it:
>
> diff --git a/lisp/isearch.el b/lisp/isearch.el
> index 96faa27..b22a775 100644
> --- a/lisp/isearch.el
> +++ b/lisp/isearch.el
> @@ -82,6 +82,7 @@ search-exit-option
> (const :tag "Edit the search string" edit)
> (const :tag "Extend the search string by motion commands" move)
> (const :tag "Extend the search string by shifted motion keys" shift-move)
> + (const :tag "Append control characters to the search string" append)
> (const :tag "Don't terminate incremental search" nil))
> :version "27.1")
>
> @@ -2452,13 +2453,18 @@ isearch-pre-command-hook
> this-command-keys-shift-translated))
> (setq this-command-keys-shift-translated nil)
> (setq isearch-pre-move-point (point)))
> + ;; Append control characters to the search string
> + ((eq search-exit-option 'append)
> + (when (cl-every #'characterp key)
> + (isearch-process-search-string key key))
> + (setq this-command 'ignore))
> ;; Other characters terminate the search and are then executed normally.
> (search-exit-option
> (isearch-done)
> (isearch-clean-overlays))
> ;; If search-exit-option is nil, run the command without exiting Isearch.
> (t
> - (isearch-process-search-string key key)))))
> + ))))
>
> (defun isearch-post-command-hook ()
> (cond
next prev parent reply other threads:[~2018-03-10 18:34 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 19:10 Let's make C-M-w in isearch yank symbol, not delete character Daniel Colascione
2018-02-23 0:44 ` John Wiegley
2018-02-25 20:55 ` Juri Linkov
2018-02-25 21:12 ` H. Dieter Wilhelm
2018-02-25 21:43 ` Daniel Colascione
2018-03-01 22:39 ` Isearch interaction model (was: Let's make C-M-w in isearch yank symbol, not delete character) Juri Linkov
2018-03-02 0:12 ` Isearch interaction model Daniel Colascione
2018-03-02 0:19 ` Davis Herring
2018-03-02 0:26 ` dancol
2018-03-03 22:50 ` Juri Linkov
2018-03-03 23:46 ` Clément Pit-Claudel
2018-03-04 21:42 ` Juri Linkov
2018-03-08 22:55 ` Juri Linkov
2018-03-04 15:39 ` Eli Zaretskii
2018-03-04 17:13 ` Daniel Colascione
2018-03-04 17:26 ` Clément Pit-Claudel
2018-03-04 21:58 ` Juri Linkov
2018-03-04 22:03 ` Daniel Colascione
2018-03-05 3:33 ` Eli Zaretskii
2018-03-05 21:33 ` Juri Linkov
2018-03-04 21:50 ` Juri Linkov
2018-03-06 21:47 ` Juri Linkov
2018-03-06 22:22 ` dancol
2018-03-07 22:30 ` Juri Linkov
2018-03-07 22:55 ` dancol
2018-03-08 22:41 ` Juri Linkov
2018-03-09 11:01 ` Daniel Colascione
2018-03-10 21:20 ` Juri Linkov
2018-03-10 21:36 ` Daniel Colascione
2018-03-11 21:58 ` Juri Linkov
2018-03-12 3:29 ` Eli Zaretskii
2018-03-12 8:23 ` Daniel Colascione
2018-03-12 9:29 ` Yuri Khan
2018-03-02 16:01 ` Isearch interaction model (was: Let's make C-M-w in isearch yank symbol, not delete character) Richard Stallman
2018-02-26 3:26 ` Let's make C-M-w in isearch yank symbol, not delete character Eli Zaretskii
2018-02-27 21:28 ` Juri Linkov
2018-02-28 3:40 ` Eli Zaretskii
2018-03-01 22:32 ` Juri Linkov
2018-03-02 8:17 ` Eli Zaretskii
2018-03-03 22:34 ` Juri Linkov
2018-03-04 15:47 ` Eli Zaretskii
2018-03-04 21:36 ` Juri Linkov
2018-03-05 3:31 ` Eli Zaretskii
2018-03-05 15:59 ` Eli Zaretskii
2018-03-05 21:25 ` Juri Linkov
2018-03-06 3:28 ` Eli Zaretskii
2018-03-06 22:07 ` Juri Linkov
2018-03-10 11:59 ` Eli Zaretskii
2018-03-10 18:34 ` John Shahid [this message]
2018-03-10 21:15 ` Juri Linkov
2018-03-11 2:37 ` Stefan Monnier
2018-03-11 21:52 ` Juri Linkov
2018-03-12 17:38 ` John Shahid
2018-03-12 18:24 ` Alan Mackenzie
2018-03-12 21:19 ` Juri Linkov
2018-03-12 21:36 ` Juri Linkov
2018-03-11 3:38 ` Eli Zaretskii
2018-03-11 14:32 ` Herring, Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvtn3hkm.fsf@gmail.com \
--to=jvshahid@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.