From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list Date: Sun, 18 Mar 2018 00:14:13 +0000 Message-ID: <87tvte44ve.fsf@tcd.ie> References: <87sha09720.fsf@tcd.ie> <87vadvvb09.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1521331996 26463 195.159.176.226 (18 Mar 2018 00:13:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Mar 2018 00:13:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30489@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 18 01:13:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exLwk-0006jo-7b for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Mar 2018 01:13:10 +0100 Original-Received: from localhost ([::1]:35411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exLyl-0002yw-Lw for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 20:15:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exLyb-0002xm-Iw for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 20:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exLyY-0005to-EJ for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 20:15:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exLyY-0005tJ-7e for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 20:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1exLyY-0001Gj-21 for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 20:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Mar 2018 00:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30489-submit@debbugs.gnu.org id=B30489.15213320634816 (code B ref 30489); Sun, 18 Mar 2018 00:15:02 +0000 Original-Received: (at 30489) by debbugs.gnu.org; 18 Mar 2018 00:14:23 +0000 Original-Received: from localhost ([127.0.0.1]:38866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exLxu-0001Fc-QA for submit@debbugs.gnu.org; Sat, 17 Mar 2018 20:14:22 -0400 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:53704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exLxt-0001FO-AQ for 30489@debbugs.gnu.org; Sat, 17 Mar 2018 20:14:22 -0400 Original-Received: by mail-wm0-f41.google.com with SMTP id e194so9292375wmd.3 for <30489@debbugs.gnu.org>; Sat, 17 Mar 2018 17:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5FmhQt15Lw+ABQkV50pGJtNQEEPf7Rk206QW1mFJ/A0=; b=KTCehDAnXA0WvaVZ5DIGWjULjEVQanr7DTqSQugoTZplVU+lJecP4TwF7526Zup87o XBiEX45IIKSAFxgnYjbsnZ/Wh68x5vMboRta3u6qHVAUrNS/F9FZEtg3s7q545zAp+iw CBzFQm3wYND7KDmoILIcyTJMPJLvj8HxMuQ0Ny8ppCph68O36qle5IVxKO2dKSA9D4WP n/AqvAsVS9uJci7g2uuLdoogCvRwbmhGyIBNHZDFP6kDDCyXQtg9xbscJshzSSxl9UEN 1GpHh8dTzp8l1+hWQ7YZUjFLbO5y3zm8ZjYXWJXW0rElX/mmiPFKqCEKJgAJ4m4dWHQV IAWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5FmhQt15Lw+ABQkV50pGJtNQEEPf7Rk206QW1mFJ/A0=; b=Y9bThHOtXK3YY5TpoD7CdqkecexyrnxJt5SDjHfM80uxIg6DwNfkhkt74r5qb1C7Ux +InxdZEzC6KEAdMq/oILSZgTc5d7mJfvK5+S9Ymv3IkHPv7gHoC94Oe4Bv4rzUQSAizk 70N6lxb94KzLMgqAM3FRYTCiVQkgqeLJV3GzCY0A0E5MMBRoCYxVHu6Zh2cB+SKJCGGu PPKEtRkZOW7sBMU7HWn338oZNHlimATJofPOH6T1paKF1di8/FQdLcfRweryerxv0svW FVdLEjva5C1/xfHIHsPpdI7l/RWZBq71m4Wwpk9S5+3zrZH6gnoI2lZWlRgrv/s/0VVz 8hAQ== X-Gm-Message-State: AElRT7HI5atGJS3xZxX0qPurUycPN2UTlZj9m/J1w/1p3lx91ZK9t3et 2GXuvM4zzjy/ix/yb9Gy/f6tvw== X-Google-Smtp-Source: AG47ELu2QcmzFmNskrzCTKSJWHYxesm48mrHLgJeyuYdoWZ1a3l7s2WXb+llrLEuBjM59op8rIYcBA== X-Received: by 10.80.173.75 with SMTP id z11mr8143207edc.306.1521332055324; Sat, 17 Mar 2018 17:14:15 -0700 (PDT) Original-Received: from localhost ([2a02:8084:4f41:8c80:9c34:da08:a010:edfc]) by smtp.gmail.com with ESMTPSA id m7sm7183172eda.36.2018.03.17.17.14.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Mar 2018 17:14:14 -0700 (PDT) In-Reply-To: <87vadvvb09.fsf@gmail.com> (Noam Postavsky's message of "Fri, 16 Mar 2018 19:47:18 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144377 Archived-At: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Pass-json-readtable-error-data-as-a-list-bug-30489.patch >From b917a7409659dde2ccc836d80741ad5a89d8785c Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Fri, 16 Feb 2018 17:11:49 +0000 Subject: [PATCH] Pass json-readtable-error data as a list (bug#30489) * lisp/json.el (json-readtable-dispatch): Fix error data. --- lisp/json.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/json.el b/lisp/json.el index b03a482ca6..d374f452e6 100644 --- a/lisp/json.el +++ b/lisp/json.el @@ -685,7 +685,7 @@ json-readtable-dispatch (push (list c 'json-read-number) table)) (pcase-dolist (`(,c . ,rest) table) (push `((eq ,char ,c) (,@rest)) res)) - `(cond ,@res (t (signal 'json-readtable-error ,char))))) + `(cond ,@res (t (signal 'json-readtable-error (list ,char)))))) (defun json-read () "Parse and return the JSON object following point. -- 2.16.2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noam Postavsky writes: > "Basil L. Contovounesios" writes: > >> @@ -685,7 +685,7 @@ json-readtable-dispatch >> (push (list c 'json-read-number) table)) >> (pcase-dolist (`(,c . ,rest) table) >> (push `((eq ,char ,c) (,@rest)) res)) >> - `(cond ,@res (t (signal 'json-readtable-error ,char))))) >> + `(cond ,@res (t (signal 'json-readtable-error ,(list char)))))) > > Actually, shouldn't this be (list ,char)? > > Otherwise, I get this warning when compiling: > > In end of data: > ../../lisp/json.el:766:1:Warning: the function =E2=80=98char=E2=80=99 is = not known to be > defined. Right you are; thanks for catching this embarrassing macro mistake. I attach an updated patch including your fix and the bug number. Thanks again, --=20 Basil --=-=-=--